CyprienBosserelle/xbeach_gpu

XBeach to XBeach-GPU parameters conversion script

davidbenncsiro opened this issue · 2 comments

davidbenncsiro commented

Being able to convert XBeach parameters for use with XBeach-GPU is useful for evaluating the behaviour of the two models and in general, for migration between them.

davidbenncsiro commented

Future Work

  • TSnode
  • change Any types in type hints to Union
  • change to Args and Returns format in function doc strings vs :param X:, :returns:
  • Instead of the user supplying directional_spread_coefficient, is there it possible to
    convert XBeach's value, e.g. 10 to 400?
  • jonswap conversion UT

Resolve or add issues.

davidbenncsiro commented

@CyprienBosserelle, it may turn out that we may yet want this script to be under a permissive licence, so it may make more sense for it to be in a separate (but also public!) repo. We should have a better idea of that next week. If that happens, I can just close the pull request and delete the branch.