Verovio neume line merge checklist
Closed this issue · 9 comments
Verovio:
- insert staff
- position of accid after staff rotation
- split
- unlink syllable: text is added, but doesn't draw the newly inserted bbox
- group: group syllable doesn't work
- ungroup: doesn't draw newly inserted bbox
- staff reorder
- insert syllable: doesn't draw newly inserted bbox
- insert clef
- update staff reorder based on new file structure
- toggle ligature jumps in x-axis
- update staff remove action #1211
- staff removing and sorting when there is only one staff in the file #1212
Neon:
- out-of-bounds error when inserting elements in a created file #1210
Docs:
- Verovio-Neon file conversion
- Verovio coordinate system conversion
Test:
- Update test files
Hi @JoyfulGen, could you please test Neon using this link before I push the changes to "production" Neon?
@yinanazhou, just to be sure, am I just checking Neon's general functioning? In particular the things listed in your comment?
Ok! Update: I used Einsie 024r from the samples folder. I started playing with the staves, splitting the first one and adding a new staff to the top of the folio and then suddenly Neon became unresponsive and nothing I did worked. I refreshed the page and now no glyphs appear and the MEI status says "unknown"... I think I broke it. Sorryyy. Is the folio broken for you too?
UPDATE: I broke another one :) I was trying to find the sequence of events that triggered it and discovered the following:
- If I split a staff, then grouped it, then tried to change the tilt, all staves would become unresponsive.
- Once, I split the staff and then changed the tilt of one half and then suddenly all liquescents had a big X next to them. It was quite cool! I was trying to reproduce this when the MEI status became unknown again.
@yinanazhou, just to be sure, am I just checking Neon's general functioning? In particular the things listed in your comment?
@JoyfulGen Neon's general functioning. The checklist above are just the issues I found when I briefly test Neon. Thanks!
Ok! Update: I used Einsie 024r from the samples folder. I started playing with the staves, splitting the first one and adding a new staff to the top of the folio and then suddenly Neon became unresponsive and nothing I did worked. I refreshed the page and now no glyphs appear and the MEI status says "unknown"... I think I broke it. Sorryyy. Is the folio broken for you too?
UPDATE: I broke another one :) I was trying to find the sequence of events that triggered it and discovered the following:
- If I split a staff, then grouped it, then tried to change the tilt, all staves would become unresponsive.
- Once, I split the staff and then changed the tilt of one half and then suddenly all liquescents had a big X next to them. It was quite cool! I was trying to reproduce this when the MEI status became unknown again.
@JoyfulGen, I've looked into this. Neon crashes because the Remove action in Verovio is not removing the entire system-measure-staff structure, instead it just removes the staff. I will let you know when I push the changes to staging. Thanks for pointing it out!
Hello again! I've found another odd behaviour. In Einsie folio 028r, I moved the last staff down to be able to create a new one in its place (I didn't want to delete a staff and break Neon again). Everything worked fine, except for one pair of neumes that refuse to group. If I try to group these two neumes with the neume, neume component, or syllable selector, I get a "Grouping Failed" notification. I've tried looking at the MEI and I can't see what's wrong! I also can't figure out what I did differently for these two neumes in particular.
Additional info: before I gave the two neumes a syllable nugget, their bounding boxes were invisible.
This is the MEI file: CH-E_611_028r_bad_neumes.mei.zip
The two neumes are called "hello1" and "hello2"
Hello again! I've found another odd behaviour. In Einsie folio 028r, I moved the last staff down to be able to create a new one in its place (I didn't want to delete a staff and break Neon again). Everything worked fine, except for one pair of neumes that refuse to group. If I try to group these two neumes with the neume, neume component, or syllable selector, I get a "Grouping Failed" notification. I've tried looking at the MEI and I can't see what's wrong! I also can't figure out what I did differently for these two neumes in particular.
Additional info: before I gave the two neumes a syllable nugget, their bounding boxes were invisible.
This is the MEI file: CH-E_611_028r_bad_neumes.mei.zip The two neumes are called "hello1" and "hello2"
Hi @JoyfulGen, about this bug, there is one space at the beginning of the file. I'm not sure if this is relevant to the bug, but I cannot reproduce it. I can group using both the syllable selector and the neume selector. Could you please check again?
But I did notice that if you selected a divLine and try to group using the neume selector, neon doesn't know that it should ignore the divLine. I will fix this.
Also, I noticed that the bounding boxes of the syllables after hello1 and hello2 are not showing. Is it the same for you? Do you remember what caused this?
@JoyfulGen, I've pushed the changes for staff removing and sorting to Neon staging.
Hi @JoyfulGen, I've checked all the items in this checklist. I will close this issue. If you find any new issues about neon staging with new Verovio, please create a new issue and mention you are using neon staging. Thanks!