Shouldn't here be a +=?

[wendlerc]

smiles-transformer/smiles_transformer/pretrain_trfm.py

Line 58 in 7ffa26e

embedded = self.pe(embedded) # (T,B,H)

[shionhonda]

You're right. It should be +=

[sevencheung2021]

so ,line 58 should be a += ?

[wendlerc]

No I think at some point I noticed it is fine the way it is.

…

On Fri, 15 Apr 2022 at 15:47, sevencheung2021 ***@***.***> wrote: so ,line 58 should be a += ? — Reply to this email directly, view it on GitHub <#20 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5YNASZ6HIIHWTZW66SINLVFFXQRANCNFSM5BE56ZRQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[VincentBt]

I agree with @ChrislyBaer, it is fine the way it is: there is no need for a "+="
See https://pytorch.org/tutorials/beginner/transformer_tutorial.html#define-the-model

[shionhonda]

@VincentBt You are definitely right. I'm sorry for confusing you all with my previous comment.