DethAriel/ng-recaptcha

Angular v16 support

Closed this issue · 10 comments

kuncevic commented

Summary

I'm submitting a:

  • [ x] other

Description

Angular v16 just got released, this package needs to be updated to support that version

arjenbrandenburgh commented

PR opened at #289

  • 👍7
MarcosPaulo775 commented

Has a forecast date for merge ?

arjenbrandenburgh commented

I cannot merge it. @DethAriel, do you happen to have time to take a look at the PR and publish a new version?

  • 👀1
MarcosPaulo775 commented

Other PR #290

CarlosTorrecillas commented

@DethAriel do you know when will you be able to merge this in? We are in the process of upgrading to Angular 16 and this is a blocker for us. Thanks!

  • 👀1
DethAriel commented

hi folks! For those of you eagerly waiting for Angular 16 support - I'm sorry you've had to wait for this long with no comms from my end.

Unfortunately, I've been busy (as most unpaid OSS maintainers are). On top of that, I've ran out of TravisCI OSS build credits (and didn't have time to migrate to Github Actions), and after me manually checking both PRs (#289 and #290), they don't seem to pass the steps CI would execute.

Here are the steps:

yarn install
yarn cypress install
yarn demo:file-gen
yarn lib:build
yarn lint
yarn prettier --check --ignore-unknown "*"
yarn demo:build
yarn ng test ng-recaptcha --code-coverage
yarn ng run demo:cypress-run

Whoever is able to produce an "Angular 16 support" PR prior to me getting enough time to do that myself that:
a) passes all of those steps successfully without producing a non-empty git diff; and
b) conforms fully to the contributing guidelines,

I'd be happy to merge such a PR into upstream and publish a new major release to NPM (looking at you @AshleyMedway @arjenbrandenburgh).

  • ❤️3
arjenbrandenburgh commented

@DethAriel My PR at #289 has been updated and all builds and tests succeed now.

  • ❤️1
AshleyMedway commented

@DethAriel #290 has been updated also. ran all scripts that you mentioned. I did run from contribution.md but I think the prettier one is not there.

I can setup the CI in our Azure DevOps account if you want?

Also I think the prettier command should be yarn prettier --check --ignore-unknown "**/*" to check all files

  • ❤️1
Dzivo commented

Do you have any news when this could be finished ? Thanks for the hard work

  • 👍4
DethAriel commented

Angular 16 support is now available in the v12.x.y branch. Happy coding everybody, and huge thx to @AshleyMedway and @arjenbrandenburgh !!

  • 🎉3