A cast to integer causes the extracted and upscaled frame count to be incorrect, on NTSC frame rate videos
Chipcraft opened this issue · 4 comments
Chipcraft commented
frame_rate = int(cap.get(cv2.CAP_PROP_FPS))
Example, input video FPS 23.976, original frame count 1212: (23 / (24000/1001)) * 1212 = 1162.6615 (i.e., 1163).
The same applies to every other video that uses frame rates that are non-even.
Everything works correctly when the cast to int is removed: frame_rate = cap.get(cv2.CAP_PROP_FPS)
Djdefrag commented
Hi my friend,
thank you, i will integrate this fix asap :)
Chipcraft commented
Hi my friend,
thank you, i will integrate this fix asap :)
Well that was quick =)
Chipcraft commented
Didn't notice until now. Same affects the video reconstruction:
QualityScaler/QualityScaler.py
Line 477 in b92bb70
Djdefrag commented
Ok perfect, changing this line too. Thanks! :D