Dr-Noob/cpufetch

Review NULL checking before free

Closed this issue · 1 comments

Dr-Noob commented

See #212. It also might be worth to:

  • Check if there are more places where calloc should be called.
  • Check if there is a way to call valgrind and don´t overwrite cpuid so it does not become Intel (and we can still check errors under AMD CPUs)
Dr-Noob commented

Nowhere in the code is checking for NULL before free (unless I missed it) and didn't find a way to run valgrind without tampering the cpuid value (I've been a long time looking for but no luck so far) so closing.