Roster members in sis course kits can be removed
joliet opened this issue · 4 comments
Describe the bug
When editing a sis course kit, I see an X for removal next to students who are in the official roster.
To Reproduce
Steps to reproduce the behavior:
- Go to kits.duke.edu
- Click on the Admin Console
- Go to View All Kits
- Search for kit TURKISH 101 - 01: Elementary Turkish (Lecture)
- Go to View/Edit members for the kit
- Click Edit Mode
- See X next to student members (aks116 and yh331 are confirmed official roster participants)
Expected behavior
Official roster participants should not be able to be removed from a sis-course kit.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
- OS: [e.g. iOS]
- Browser [e.g. chrome, safari]
- Version [e.g. 22]
Smartphone (please complete the following information):
- Device: [e.g. iPhone6]
- OS: [e.g. iOS8.1]
- Browser [e.g. stock browser, safari]
- Version [e.g. 22]
Additional context
Add any other context about the problem here.
Hi Joile, I am not sure how to test this. I guess we can just watch for additional issues? I will move it into production next week.
This is now moved to production. The issue was caused by students/instructors being added to a Kit and then later being part of the official roster. To fix this, when we are notified that a person has been added to the roster, we verify they are not already a member of a _added group. If they are, we remove that membership.
Thanks, Liz. I think we decided that I couldn't test this so closing.