Dunmail/personal-demographics-service-api

Specifications for NHS Digital APIs provided on the API Management Platform

personal-demographics-service-api

This is a RESTful HL7® FHIR® API specification for the Personal Demographics Service.

• specification/ This Open API Specification describes the endpoints, methods and messages exchanged by the API. Use it to generate interactive documentation; the contract between the API and its consumers.
• sandbox/ This NodeJS application implements a mock implementation of the service. Use it as a back-end service to the interactive documentation to illustrate interactions and concepts. It is not intended to provide an exhaustive/faithful environment suitable for full development and testing.
• scripts/ Utilities helpful to developers of this specification.
• apiproxy/ The Apigee API Proxy

Consumers of the API will find developer documentation on the NHS Digital Developer Hub.

Contributing

Contributions to this project are welcome from anyone, providing that they conform to the guidelines for contribution and the community code of conduct.

Licensing

This code is dual licensed under the MIT license and the OGL (Open Government License). Any new work added to this repository must conform to the conditions of these licenses. In particular this means that this project may not depend on GPL-licensed or AGPL-licensed libraries, as these would violate the terms of those libraries' licenses.

The contents of this repository are protected by Crown Copyright (C).

Development

Requirements

• make
• nodejs v12 or v14
• npm/yarn
• poetry

Install

$ make install

Updating hooks

You can install some pre-commit hooks to ensure you can't commit invalid spec changes by accident. These are also run in CI, but it's useful to run them locally too.

$ make install-hooks

Environment Variables

Various scripts and commands rely on environment variables being set. These are documented with the commands.

💡 Consider using direnv to manage your environment variables during development and maintaining your own .envrc file - the values of these variables will be specific to you and/or sensitive.

Make commands

There are make commands that alias some of this functionality:

• lint -- Lints the spec and code
• publish -- Outputs the specification as a single file into the dist/ directory
• serve -- Serves a preview of the specification in human-readable format
• generate-examples -- generate example objects from the specification
• validate -- validate generated examples against FHIR R4

Running tests

Sandbox Tests

Start the sandbox locally:

make sandbox

To run local tests, use:

make test-sandbox

VS Code Plugins

• openapi-lint resolves links and validates entire spec with the 'OpenAPI Resolve and Validate' command
• OpenAPI (Swagger) Editor provides sidebar navigation

Emacs Plugins

• openapi-yaml-mode provides syntax highlighting, completion, and path help

Speccy

Speccy A handy toolkit for OpenAPI, with a linter to enforce quality rules, documentation rendering, and resolution.

Speccy does the lifting for the following npm scripts:

• test -- Lints the definition
• publish -- Outputs the specification as a single file into the dist/ directory
• serve -- Serves a preview of the specification in human-readable format

(Workflow detailed in a post on the developerjack blog.)

💡 The publish command is useful when uploading to Apigee which requires the spec as a single file.

Caveats

Swagger UI

Swagger UI unfortunately doesn't correctly render $refs in examples, so use speccy serve instead.

Apigee Portal

The Apigee portal will not automatically pull examples from schemas, you must specify them manually.

Postman Collection

Patient Demographics Sandbox.postman_collection must be kept in sync with the OAS and Sandbox manually.

Procedure:

• Import the collection into Postman
• Update requests and export the collection back into the repo
• Re-generate the Run in Postman button Markdown button link and update the OAS

Deployment

Specification

Update the API Specification and derived documentation in the Portal.

make deploy-spec with environment variables:

• APIGEE_USERNAME
• APIGEE_PASSWORD
• APIGEE_SPEC_ID
• APIGEE_PORTAL_API_ID

API Proxy & Sandbox Service

Redeploy the API Proxy and hosted Sandbox service.

make deploy-proxy with environment variables:

• APIGEE_USERNAME
• APIGEE_PASSWORD
• APIGEE_ORGANIZATION
• APIGEE_ENVIRONMENTS - Comma-separated list of environments to deploy to (e.g. test,prod)
• APIGEE_APIPROXY - Name of the API Proxy for deployment
• APIGEE_BASE_PATH - The proxy's base path (must be unique)

💡 Specify your own API Proxy (with base path) for use during development.

Platform setup

Successful deployment of the API Proxy requires:

1. Target Servers:
   1. spine-demographics: Gateway to PDS API
   2. spine-demographics-int Gateway to PDS INT API (Only avaliable for pull requests)
   3. identity-server - Identity Provider's OAuth server
2. An encrypted (for production) Key-Value Map named pds-variables-encrypted, containing:
   1. Key: NHSD-ASID, Value: Accredited System ID (ASID) identifying the API Gateway
3. A Key-Value Map named pds-variables, containing:
   1. Key: jwks_path, Value: Path on identity-server Target Server to JSON Web Key Set (JWKS)

💡 For Sandbox-running environments (test) these need to be present for successful deployment but can be set to empty/dummy values.