missing credits + latest additions

[tobozo]

This project uses derived code from @G6EJD's great work but it looks like you forgot to add a couple of links in the credits.

I recently added waveform support and some controls to tweak the settings, you may be interested in the latest changes.

[G6EJD]

Yes I see both mine and tobozo’s code contributions please add the required credits so we don’t have to go through any take-down procedures and no-one wants to do that. Either that or create your own completely new software design to replace this. Thank you.

[ElectroMagus]

My apologies- I'm on vacation and can add credit when I get back later this week.

…

On Sat, Jul 28, 2018 at 5:57 AM, G6EJD ***@***.***> wrote: Yes I see both mine and tobozo’s code contributions please add the required credits so we don’t have to go through any take-down procedures and no-one wants to do that. Either that or create your own completely new software design to replace this. Thank you. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ALClRrToOcUGgzEgfp-86KynNY7OSTROks5uLEOzgaJpZM4Vk_9G> .

[ElectroMagus]

My apologies- I'm on vacation and can add credit when I get back later this week.

…

On Sat, Jul 28, 2018 at 5:46 AM, tobozo ***@***.***> wrote: This project uses derived code from @G6EJD <https://github.com/G6EJD>'s great work <https://github.com/G6EJD/ESP32-8-Octave-Audio-Spectrum-Display> but it looks like you forgot to add a couple of links in the credits. I recently added waveform support and some controls to tweak the settings, you may be interested in the latest changes <https://github.com/tobozo/ESP32-Audio-Spectrum-Waveform-Display/tree/odroid-go> . — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ALClRn1u1gevwOS3821wTDHPkkDEX9D2ks5uLED2gaJpZM4Vk_9G> .

[G6EJD]

OK, we are pleased you have found our code useful but nonetheless the need to recognise the copyright owners does not go away and we look forward to you making the amendments in due course.

[tobozo]

bump

[G6EJD]

I wonder if he did?

[tobozo]

Holidays tend to create amnesy once they're past, so I created this pull request :-)

@G6EJD on the other hand your repo is missing a License file, which may be encouraging what is happening here.

[G6EJD]

I've added a licence now, thanks for the hint. I await a response to the pull request...

[ElectroMagus]

Hey- Sorry. I've been traveling alot the past few months and this completely slipped my mind. I'll add the credits when I get home tonight or first thing in the morning. Thanks

…

On Fri, Oct 5, 2018 at 9:32 AM G6EJD ***@***.***> wrote: I've added a licence now, thanks for the hint. I await a response to the pull request... — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ALClRvzGaIE04KApywpizrwRBwM_J6kZks5uh219gaJpZM4Vk_9G> .

[G6EJD]

No credits added yet...

[ElectroMagus]

Added credit in the README. I'll add notes in the code once I am able to get back home (traveling for family issue).

…

On Sun, Oct 14, 2018 at 7:19 AM G6EJD ***@***.***> wrote: No credits added yet... — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ALClRnxgw6odO2yFTECgVW5KzbQuYfajks5ukyvYgaJpZM4Vk_9G> .

[tobozo]

thanks for finding the time to update :-)