GRG GP tools that use Alpha-Alpha or Numeric-Numeric labeling style should employ separator
Closed this issue · 9 comments
The Create GRG from Area and Create GRG from Point tools both have an Alpha-Alpha and Numeric-Numeric labeling options.
The labels should have a separator.
See discussion here:
Esri/solutions-grg-widget#16 (comment)
Addressed in PR #640
The changes have been made to the code within the solutions-geoprocessing-toolbox repo but have not been applied to any of the solutions.
Documentation will require an update
This change will need to be updated in the GRG solution and the Clearing Ops solution.
I have verified that the "-" separator has been added to the new layout for the GRG Tools. These tools are also the Clearing Operations toolbox. Going forward I think we should blow away the duplicate tools in the Clearing Operations toolbox and have the GRG Tools just in the GRG toolbox. Then when we release the update to the solution we can just pull in the Clearing Operations toolbox to give us the Number Features tool and the GRG toolbox to give us the GRG tools.
The result of this would allow us to only have to maintain the tools in one location.
Can we use this item as the item to release the Clearing Ops and the GRG Updates or do we need a new item to track these changes?
I have updated the checklist task in the following repo:
https://github.com/ArcGIS/solutions-defense-test-catalog/blob/master/Tests/Clearing-Operations_ArcGIS-Pro.md
https://github.com/ArcGIS/solutions-defense-test-catalog/blob/master/Tests/Clearing-Operations_ArcMap.md
I need someone to verify that what I have added to the checklist tests are good enough for the features that have been added.
Reopening issue to fix unit tests that broke when parameter list changed.
verified.