Eyescale/CMake

Implement QUIET for FindMaya

tribal-tec opened this issue · 3 comments

tribal-tec commented

When used within Buildyard, the finder returns

FATAL_ERROR:MAYA_ROOT_DIR is NOT found

I guess that's a typo, but even then it should not exit fatally, but consider QUIET instead.

eile commented

That can't be right:

IF(MAYA_ROOT_DIR)
  SET(MAYA_FOUND "TRUE")
ELSE(MAYA_ROOT_DIR)
  SET(MAYA_FOUND "")

  # Include & libraries directories
  SET(MAYA_INCLUDE_DIR "${MAYA_ROOT_DIR}/include")
  SET(MAYA_LIBRARY_DIR "${MAYA_ROOT_DIR}/lib")

So you only set include/lib dirs if maya root is not found -- to notfound/include!

Also consider using FindPackageHandleStandardArgs like all the other finders.

marwan-abdellah commented

So, that's true. Still wondering how did I push such commit!