Some async methods throw InvalidOperationException

Question

Some async methods throw InvalidOperationException

GeertvanHorrik opened this issue 5 years ago · 4 comments

Describe the issue

With the new update, some (not all!) methods throw this exception:

System.InvalidOperationException: 'Could not execute the method because either the method itself or the containing type is not fully instantiated.'

Minimal Repro

This happens to Orchestra. I will try to figure out what exactly is happening and why it's causing issues.

Make an effort to fix the bug

Working on it!

Answer 1 · 2019-11-04T22:03:10.000Z

Seems to happen on generic methods (so not the class, but the method is generic).

Answer 2 · 2019-11-04T22:31:20.000Z

Figured it out, the casts don't have the generic info on them:

Answer 3 · 2019-11-04T23:12:23.000Z

Looks much better since there is no need for casting anymore (since using the right generic instance types):

Answer 4 · 2019-11-04T23:17:24.000Z

Interesting, this bug has been in there forever, just never caused exceptions. The reason it's breaking now is because I've moved the Stop logic into a separate method (smaller IL code).