FraserChapman/plunger

BUG - version 1.0.1

Opened this issue · 2 comments

shed25 commented

Describe the bug
Double sound.
Sometimes it looks like there are two instances of video. One is behind, and out of control and another is in iframe.
When I click pause on iframe I still hear the sound of the same video.
Even if I remove all elements from body, I still hear the sound of the same video.
Sporadic behavior.
Mostly happens when you reopen previously closed video.
Looks like bowser keeps in memory previous youtube video instance run it and keep connection with youtube even the youtube player is removed from DOM.

Screenshots
If applicable, add screenshots to help explain your problem.

System information

Additional context
Add any other context about the problem here.

FraserChapman commented

Hi @shed25

Thanks for the detailed report, whilst the extension can be used by the Brave browser, it isn't officially supported.

This extension is only currently supported on Chrome, Firefox, and Edge. While I understand that Brave supports the same extensions as Chrome through the Chrome Web Store, there may be some differences in compatibility. Mainly because Brave has its own blocker, meaning this extensions may not work correctly...

As I am sure you can imagine there is an immense challenge in testing every browser in combination with each ad-blocker, and as such it's necessary to restrict the scope to a manageable extent.

That said, I've gone ahead and installed Brave to explore and understand the specific issue at hand. However, at this time, I'm unable to guarantee support for every possible browser.

Hope this makes sense, if I do have a fix and can offer support for Brave I will update the project :)

p.s. I notice you say this is with version 1.0.0 - there was a tiny bug with the enhanced privacy setting in this version, the current version 1.0.1 might work as it uses the correct YT domain rather than the no-cookie variant by default.

FraserChapman commented

Ok I think I can see what is happening here - it is to do with how YT's base.js is calling fetch. Suffice to say I think I have a working fix for it, just testing it now. I will update you if I push a new version (will be 1.0.2) - again, thanks for raising this and providing the information. Most helpful :)

  • 👍1