FredKSchott/pika-pack

"dist-src/" does not exist, or was not yet created in the pipeline.

Closed this issue · 12 comments

YerkoPalma commented

Hi 👋

I'm having troubles running the build command, following what readme says.

with this config

"@pika/pack": {
    "pipeline": [
      [ "@pika/plugin-standard-pkg" ],
      [ "@pika/plugin-build-web" ]
    ]
  },

I get this error

image

I'm running node v11.5.0 and npm v6.4.1 and working on with git-bash on windows 10

Any ideas how to fix this error?

FredKSchott commented

Hmm, I bet this is a windows path issue (if you have a Linux or Mac system, it would be great if you could try there to confirm that this is windows specific).

I’ll plan to spin up my VM and debug this tonight/tomorrow if no one has been able to fix it sooner

YerkoPalma commented

Honestly, I also though it was some windows related issue, but the same happens on an ubuntu machine

image

Here is my full project, in case is some particular error of it
https://github.com/YerkoPalma/compass

FredKSchott commented
FredKSchott commented

Actually, looking at your project, I think the error is really happening in the previous plugin.

@pika/pack assumes a standard package structure, where your source code lives in a ‘src’ directory. To use pika, you’ll want to move your source JS code (including index.js) to a src/ directory. assets/ can remain top-level.

Btw this is 100% something that needs to be documented better in the README.

  • 👍1
YerkoPalma commented

Oh! that was unexpected.
You are right, moving every js file to a src folder fix it.

Thanks

FredKSchott commented

No problem! Thanks for testing this out!

If you don’t mind, im going to leave this issue open to track:

  • documenting this structure better
  • why didn’t the source builder catch that?
YerkoPalma commented

Ok, no problem.

IMO this should be a configurable option 👍

ithinkihaveacat commented

+1 please document the state the package needs to be in before running @pika/pack!

From reading the docs (e.g. "This lets @pika/pack build your package without much (if any) configuration required on your part"), I got the impression that no particular setup would be required.

(This did sound a bit too good to be true, but I don't have a great understanding of how npm packages are made (hence my interest in this project…), so I thought this might actually be possible.)

FWIW the reduced test case I put together before finding this issue is at https://github.com/ithinkihaveacat/pack-test.

matiascarranza commented

+1 for adding this to the docs & configuration option

FredKSchott commented

I have a draft of the blog post I plan to release asap that goes into more detail on the package structure. You can view it here: https://next.pikapkg.com/blog/a-standard-package-format (very much in draft form, some things may change before release, please leave feedback if you have any, etc!)

The plan would be to post that, clean up the standard-pkg README, and then link to the two in all the relevant places (@pika/pack, dependent plugin READMEs, etc)

  • 👍2
FredKSchott commented

Error message fixed here: FredKSchott/pika-pack-builders@b2e5a8b

Will go out in the next release

zoltanbedi commented

I'm facing this issue as well. Not sure how to resolve it. Tried with wsl and windows. the pkg folder is not created.

  • 👍1