Build Error
Closed this issue · 3 comments
I tried to build this emulator, but I get the following build error (on MacOS):
--> src/frontend/renderer.rs:57:7
|
57 | FrameState::Even => FrameState::Odd,
| ^^^^^^^^^^^^^^^^ help: consider using a reference: `&FrameState::Even`
error[E0658]: non-reference pattern used to match a reference (see issue #42640)
--> src/frontend/renderer.rs:58:7
|
58 | FrameState::Odd => FrameState::Even,
| ^^^^^^^^^^^^^^^ help: consider using a reference: `&FrameState::Odd
error: aborting due to 2 previous errors
error: Could not compile `mooneye-gb`.
Any ideas what is causing this and how to fix? Thanks! Very interested in and excited about this project.
Not an expert on this repo (just playing around / experimenting with it) but it looks like this is from commit 2a05402
I built 94a8685 and it worked & could run a ROM.
Also, looks like I have to install the sdl2 library on Mac. (figured this out from reading the travis file). I can submit a PR to add this to the documentation if you'd like. The documentation for running the GUI seems out of date as well: "Follow the instructions" -- I don't see any instructions.
Awesome project!
Sorry! That compilation error was caused by an accidental bump of minimum Rust version to 1.26. It wasn't intended but I don't provide backwards compatibility, so I'll just leave it as it is. I added a mention of the minimum Rust version and SDL2 to the readme.
The GUI problem was caused by a backwards-incompatible change in imgui, which wasn't caught because it still compiled without errors. I've added a workaround in a3fb4a2 so you should see the notification now if you're missing the boot ROM.
The problems have been fixed so I'll close this