Compilation issue on new 2.9.0

Question

Compilation issue on new 2.9.0

kerautret opened this issue 2 years ago · 5 comments

When trying the new version I obtain this errors. (it was working in previous version for instance from 3050415)

qglviewer.cpp:661:3: error: no matching member function for call to 'disconnect'
disconnect(screen(), SIGNAL(physicalDotsPerInchChanged(qreal)), this->camera(), SLOT(setDevicePixelRatio(qreal)));
^~~~~~~~~~
/opt/homebrew/Cellar/qt@5/5.15.6/lib/QtCore.framework/Headers/qobject.h:351:17: note: candidate function not viable: cannot convert argument of incomplete type 'QScreen *' to 'const QObject *' for 1st argument
static bool disconnect(const QObject *sender, const char *signal,
^
/opt/homebrew/Cellar/qt@5/5.15.6/lib/QtCore.framework/Headers/qobject.h:384:24: note: candidate function template not viable: no known conversion from 'const char[28]' to 'void **' for 4th argument
static inline bool disconnect(const typename QtPrivate::FunctionPointer::Object *sender, Func1 signal,
^
/opt/homebrew/Cellar/qt@5/5.15.6/lib/QtCore.framework/Headers/qobject.h:353:17: note: candidate function not viable: cannot convert argument of incomplete type 'QScreen *' to 'const QObject *' for 1st argument
static bool disconnect(const QObject *sender, const QMetaMethod &signal,
^
/opt/homebrew/Cellar/qt@5/5.15.6/lib/QtCore.framework/Headers/qobject.h:367:24: note: candidate template ignored: substitution failure [with Func1 = const char *, Func2 = const char *]: no type named 'Object' in 'QtPrivate::FunctionPointer<const char *>'
static inline bool disconnect(const typename QtPrivate::FunctionPointer::Object *sender, Func1 signal,
^ ~~~~~~
/opt/homebrew/Cellar/qt@5/5.15.6/lib/QtCore.framework/Headers/qobject.h:355:17: note: candidate function not viable: requires at most 3 arguments, but 4 were provided
inline bool disconnect(const char *signal = nullptr,
^
/opt/homebrew/Cellar/qt@5/5.15.6/lib/QtCore.framework/Headers/qobject.h:358:17: note: candidate function not viable: requires at most 2 arguments, but 4 were provided
inline bool disconnect(const QObject *receiver, const char *member = nullptr) const
^
/opt/homebrew/Cellar/qt@5/5.15.6/lib/QtCore.framework/Headers/qobject.h:360:17: note: candidate function not viable: requires 1 argument, but 4 were provided
static bool disconnect(const QMetaObject::Connection &);
^
qglviewer.cpp:669:39: error: member access into incomplete type 'QScreen'
camera->setDevicePixelRatio(screen()->devicePixelRatio());
^
/opt/homebrew/Cellar/qt@5/5.15.6/lib/QtGui.framework/Headers/qcursor.h:51:7: note: forward declaration of 'QScreen'
class QScreen;
^
qglviewer.cpp:674:3: error: no matching member function for call to 'connect'
connect(screen(), SIGNAL(physicalDotsPerInchChanged(qreal)), camera, SLOT(setDevicePixelRatio(qreal)));
^~~~~~~
/opt/homebrew/Cellar/qt@5/5.15.6/lib/QtCore.framework/Headers/qobject.h:222:36: note: candidate function not viable: cannot convert argument of incomplete type 'QScreen *' to 'const QObject *' for 1st argument
static QMetaObject::Connection connect(const QObject *sender, const char *signal,
^
/opt/homebrew/Cellar/qt@5/5.15.6/lib/QtCore.framework/Headers/qobject.h:225:36: note: candidate function not viable: cannot convert argument of incomplete type 'QScreen *' to 'const QObject *' for 1st argument
static QMetaObject::Connection connect(const QObject *sender, const QMetaMethod &signal,
^
/opt/homebrew/Cellar/qt@5/5.15.6/lib/QtCore.framework/Headers/qobject.h:481:41: note: candidate function not viable: cannot convert argument of incomplete type 'QScreen *' to 'const QObject *' for 1st argument
inline QMetaObject::Connection QObject::connect(const QObject *asender, const char *asignal,
^
/opt/homebrew/Cellar/qt@5/5.15.6/lib/QtCore.framework/Headers/qobject.h:242:43: note: candidate template ignored: substitution failure [with Func1 = const char *, Func2 = const char *]: no type named 'Object' in 'QtPrivate::FunctionPointer<const char *>'
static inline QMetaObject::Connection connect(const typename QtPrivate::FunctionPointer::Object *sender, Func1 signal,
^ ~~~~~~
/opt/homebrew/Cellar/qt@5/5.15.6/lib/QtCore.framework/Headers/qobject.h:283:13: note: candidate template ignored: requirement 'int(QtPrivate::FunctionPointer<const char *>::ArgumentCount) >= 0 && !QtPrivate::FunctionPointer<const char *>::IsPointerToMemberFunction' was not satisfied [with Func1 = const char *, Func2 = const char *]
connect(const typename QtPrivate::FunctionPointer::Object *sender, Func1 signal, const QObject *context, Func2 slot,
^
/opt/homebrew/Cellar/qt@5/5.15.6/lib/QtCore.framework/Headers/qobject.h:322:13: note: candidate template ignored: substitution failure [with Func1 = const char *, Func2 = const char *]: no type named 'Object' in 'QtPrivate::FunctionPointer<const char *>'
connect(const typename QtPrivate::FunctionPointer::Object *sender, Func1 signal, const QObject *context, Func2 slot,
^ ~~~~~~
/opt/homebrew/Cellar/qt@5/5.15.6/lib/QtCore.framework/Headers/qobject.h:274:13: note: candidate function template not viable: requires 3 arguments, but 4 were provided
connect(const typename QtPrivate::FunctionPointer::Object *sender, Func1 signal, Func2 slot)
^
/opt/homebrew/Cellar/qt@5/5.15.6/lib/QtCore.framework/Headers/qobject.h:314:13: note: candidate function template not viable: requires 3 arguments, but 4 were provided
connect(const typename QtPrivate::FunctionPointer::Object *sender, Func1 signal, Func2 slot)

Answer 1 · 2022-12-29T13:37:57.000Z

Thank you for this feedback. This is Qt5 specific, I'll add a Qt5 build in the push actions to catch these.

Answer 2 · 2022-12-29T13:38:14.000Z

Fixed in v2.9.1

Answer 3 · 2022-12-29T15:15:27.000Z

Thanks, if I well understand the fix of issue #22 will work only using qt 6 ?

Answer 4 · 2022-12-30T20:13:09.000Z

No, the #22 fix should work with both Qt 5 and 6. What I meant is that the *compilation error* in #64 was Qt5 specific, and is solved in v2.9.1 (with an added Qt5 build GitHub action to catch other similar problems).

…

On Thu, Dec 29, 2022 at 4:15 PM Bertrand Kerautret ***@***.***> wrote: Thanks, if I well understand the fix of issue #22 <#22> will work only using qt 6 ? — Reply to this email directly, view it on GitHub <#64 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAOPFGVEBTZODKNIDRM67ZLWPWTJTANCNFSM6AAAAAATL6B2TU> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>

Answer 5 · 2022-12-30T20:34:13.000Z

I just tested and it perfectly works on QT5 thanks ;)