Gmousse/dataframe-js

Any plan on supporting TypeScript with a Definitions.ts file?

Closed this issue · 8 comments

willkara commented

Trying to use it in my AngularCLI project with TypeScript.

I tried importing with yarn and even adding the CDN version but it's either asking for the types or not working at all. Maybe a types file can be created for https://github.com/DefinitelyTyped/DefinitelyTyped

Perhaps there is another way to import it?

Would love it if someone could point me in the right direction :)

Gmousse commented

Hi @willkara,

I haven't knowledges about typescript (and how a js module can be used on it).

I will do some researches and tell some friends.

If a configuration file is required, i will create a pull request. Stay tuned

Gmousse commented

@willkara I have created a dts file (using dts-gen).
It seems to work.

Can you try to install the PR branch using npm or yarn (example: npm install git+https://github.com/Gmousse/dataframe-js.git#feature/support-typescript) and test it ?

If it works I will merge (and it will be in the incoming release).
Thanks !

willkara commented

@Gmousse Thanks for being so receptive! I'll give it a shot once I get home :)

willkara commented

Still trying to get it to work correctly but haven't had enough time to really put some decent time into it.

Also, you might want to look into DefinitleyTyped until you can think of making it es2016 compatible with modules.

Just as an FYI, I tried using it outside of this project and it's working amazingly well! :)

Thanks!

willkara commented

I can confirm it works!

danielgwilson commented

Any plans to get this into DefinitelyTyped?

Gmousse commented

Hi @danielgwilson,

Sadly I haven't use TypeScript and I don't know its stack.
I don't have the time now top support actively the library for TypeScript users.
But you are free to open a Pull Request for that.

Gmousse commented

closed in favor of #73