Build is failing

Question

Build is failing

Closed this issue 5 years ago · 4 comments

JuanMaRuiz commented 5 years ago

Hi! after published the last version of psi the build is failing.

I have created this PR to try to fix it.

Best regards.

Answer 1 · 2019-11-19T01:18:08.000Z

Absolute champ! Saw the PR, but I've been busy with Chrome Dev Summit. My bad 🙏

I think the build failures are a result of flakyness on PSI and not this repo. I am looking at it from the other end to try to fix that. Might not need that PR to fix the build, but def like the new tests!

Answer 2 · 2019-11-20T20:14:21.000Z

Absolute champ! Saw the PR, but I've been busy with Chrome Dev Summit. My bad 🙏

No worries.

I think the build failures are a result of flakyness on PSI and not this repo. I am looking at it from the other end to try to fix that. Might not need that PR to fix the build, but def like the new tests!

Let me know if I could help in any way.

Best regards.

Answer 3 · 2019-11-27T22:31:59.000Z

exterkamp commented 5 years ago

Answer 4 · 2019-11-27T22:56:25.000Z

Good job @exterkamp!!!

…

On Wed, Nov 27, 2019 at 11:32 PM Shane Exterkamp ***@***.***> wrote: [image: image] <https://user-images.githubusercontent.com/6392995/69763638-aa2f2c80-1122-11ea-9c14-7509e4dc7168.png> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#106?email_source=notifications&email_token=AAOAUUU4KWIGZH7GY76A46DQV3YN7A5CNFSM4JOYOCKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFK5HVA#issuecomment-559272916>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAOAUUX5HBTA3EGG2AYLC5LQV3YN7ANCNFSM4JOYOCKA> .

-- *JuanMa Ruiz* *Front-End Developer* @rjuanma www.juanmaruiz.es