Code Review with someone from the CFT team

Question

Code Review with someone from the CFT team

anners opened this issue 6 years ago · 4 comments

anners commented 6 years ago

Maybe @morgante or someone from his team can do a code review.

Answer 1 · 2019-05-14T21:58:33.000Z

The code review is complete. Most of the feedback has been incorporated as issues in this project (#49, #50, #51)

Answer 2 · 2019-05-15T17:17:07.000Z

@jmound Who provided the review?

Answer 3 · 2019-05-15T17:51:45.000Z

We met with @glarizza yesterday.

Answer 4 · 2019-05-15T18:03:25.000Z

@jmound The review I did you with and Chris was a general overview and making recommendations based on how I would expect the code to be laid out. I didn't pour through line-by-line and do a thorough and complete review - I'd expect that's something you'll still want to be done once you've addressed the comments I made yesterday.