Allow the max cache lifetime to be set

Question

GrahamCampbell opened this issue 8 years ago · 5 comments

The current default is 30 days. There are cases where people will want to lower this where they are sending millions of requests.

Answer 1 · 2017-06-24T12:22:06.000Z

NB ['cache_lifetime' => $time_in_seconds] should be the 2nd parameter passed to addCache when implemented in getBuilder of GitHubFactory

Answer 2 · 2017-07-29T23:44:37.000Z

Lowered the default to 48 hours.

Answer 3 · 2017-07-29T23:44:46.000Z

Still no option to set as of yet.

Answer 4 · 2017-07-29T23:45:16.000Z

Also, changed the caching system to strictly only cache using etags, so always sending requests: c0b74de.

Answer 5 · 2017-08-06T18:18:52.000Z

I think this is fine now.