Replace Concrete.hs with ConcreteNew.hs

[johnjcamilleri]

These two modules are completely commented out:

• src/compiler/GF/Compile/Compute/Concrete.hs
• src/compiler/GF/Compile/TypeCheck/Concrete.hs

Seemingly replaced by these:

• src/compiler/GF/Compile/Compute/ConcreteNew.hs
• src/compiler/GF/Compile/TypeCheck/ConcreteNew.hs

Given that this seems to have been the case since ~2014, surely we can simply delete the empty modules and replace them with the "new" ones.

[krangelov]

Not exactly. There are three different implementations for the type checker: GF.Compile.TypeCheck.Concrete - the original type checker in GF GF.Compile.TypeCheck.RConcrete - a version of the above modified by Aarne to allow record extensions to override existing fields. GF.Compile.TypeCheck.ConcreteNew - a completely new version by me which allows full type inference and supports implicit arguments. The latest is not quite complete and was therefore never activated. It does, however, type check the English RGL. What happened is that RConcrete replaced Concrete. It makes sense to rename RConcrete to Concrete and remove the old version. On the other hand GF.Compile.Compute.ConcreteNew has been used now for a few years and the old GF.Compile.Compute.Concrete is safe to remove.

…

On Wed, 30 Jun 2021 at 14:05, John J. Camilleri ***@***.***> wrote: These two modules are completely commented out: - src/compiler/GF/Compile/Compute/Concrete.hs - src/compiler/GF/Compile/TypeCheck/Concrete.hs Seemingly replaced by these: - src/compiler/GF/Compile/Compute/ConcreteNew.hs - src/compiler/GF/Compile/TypeCheck/ConcreteNew.hs Given that this seems to have been the case since ~2014, surely we can simply delete the empty modules and replace them with the "new" ones. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#117>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEYFSZEONBRWICJ4HNPHVXLTVMCCPANCNFSM47SGCFOQ> .

[johnjcamilleri]

Thanks for the explanation, Krasimir!
I can add PR with these changes soon.