Bottom / Middle vertical alignment of text in a text frame is not working properly

Question

Bottom / Middle vertical alignment of text in a text frame is not working properly

dkgh707 opened this issue 8 years ago · 5 comments

I have discovered a problem when attempting to adjust the alignment of text vertically within a text box. If the "Middle" or "Bottom" vertical alignment setting is chosen from the Columns & Text Distances tab, the text will be placed too low in the text box. I have not yet located the root cause of the problem, but I have traced the issue to an incorrect hAdjust value on line 2976 of pageitem_textframe.cpp. The function textLayout.box()->naturalHeight() is returning a value of zero instead of the proper height of the text. I think this problem was introduced in one of the commits that occurred between mid and late July.

Thanks,
Dave

Answer 1 · 2016-09-17T00:29:28.000Z

Thanks Dave for reporting & analysis. Since I am busy these days with other
things, I appreciate if you can send a pull request.

On 16 Sep 2016 7:54 a.m., "dkgh707" notifications@github.com wrote:

I have discovered a problem when attempting to adjust the alignment of text
vertically within a text box. If the "Middle" or "Bottom" vertical
alignment setting is chosen from the Columns & Text Distances tab, the
text will be placed too low in the text box. I have not yet located the
root cause of the problem, but I have traced the issue to an incorrect
hAdjust value on line 2976 of pageitem_textframe.cpp. The function
textLayout.box()->naturalHeight() is returning a value of zero instead of
the proper height of the text. I think this problem was introduced in one
of the commits that occurred between mid and late July.

Thanks,
Dave

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#219, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABjpNmq_hqvlwwMQqfNBc4-U7SMk1r7sks5qqhLZgaJpZM4J-kqH
.

Answer 2 · 2016-09-18T21:55:36.000Z

I'd be happy to make a pull request, but I am unfamiliar with how the project is structured. Since I do not have permissions to create a branch for this issue, I am not sure what exactly you want me to do.

Thanks,
Dave

Answer 3 · 2016-09-19T01:46:12.000Z

The easiest way is to fix the problem in your computer then make a patch and attach here.

Answer 4 · 2016-10-22T09:15:35.000Z

please test now. It should be fixed by ebbc3a9

Answer 5 · 2016-10-30T06:16:56.000Z

closing this now, please reopen it if you have a problem.