HPDCS/ROOT-Sim

Refactor models

Closed this issue · 5 comments

Models should be reorganized, so as to be more customizable. This will help a lot in devising experiments for the papers, and for (future) test cases.

This issue depends on #15 as we definitely need macros to simplify rewriting everything.

Airport has several flaws. The first ones that I've spot are:

  • ScheduleNewEvent() is called in OnGVT() [partially fixed in commit 732ff18]
  • There are support functions which pass as the payload of a message a pointer to the internal state
  • There are a lot of pointless malloc() calls in the code
  • Some malloc() calls for temporary buffers don't have the corresponding free()
  • Routes as LPs are not really useful as they are now

Remember to introduce Makefiles to simplify the model build process.

Makefiles for models have been introduced in commit 8a8a885.

There are models, such as collector, which are in the /models just to support specific coverage tests. These should be moved to /tests, to leave in /models only the real models.

On hold, planned for v3.x