Port `pdb.rs` from nom to binrw
Holzhaus opened this issue · 7 comments
@Swiftb0y is working on a PoC: #39 (comment)
Reporting the progress just so you won't think I vanished:
I took a slightly different approach compared to #47. I think I got a working implementation for reading and writing (!) DeviceSQL strings. I wrote the string as their own standalone module. I will open a PR as soon as I wrote enough unit tests to be confident for the implementation to be correct. I don't know how much time I'll have during this weekend, so don't expect a PR before tuesday.
I'm now working on an implementation strategy for Rows. If they contain more than one column that contains strings, they are allocated at the end of the row and addressed using an offset. This more or less forces the use of a FilePtr which can't do serialization yet (see jam1garner/binrw#4). After spending a couple days trying to find a workaround, I decided to give up and just implement this read-only until an upstream solution has been found.
Ok, could you open a draft PR?
Unfortunately I still haven't gotten anywhere. I caught covid a week earlier and now I've got other priorities. The only progress I made so far can be sketched out in a couple of lines. I'll open a PR later today.
I caught covid a week earlier
Sorry to hear that. I hope you get well soon!
Thanks, I'm healthy again but I need to work through the backlog of tasks that accumulated during that week until I can shift my focus back to the more time-consuming work related to rekordcrate
I'm giving up on this issue for now. I'm not making any progress and there is too much going on IRL for me atm. Feel free to takeover if you have time. I'm sorry. Thanks for your understanding.