Don't return from VCL discard failure
Closed this issue · 0 comments
cin commented
{"level":"error","ts":1618966483.733197,"logger":"controller-runtime.manager.controller.varnish-controller","caller":"controller/controller.go:301","msg":"Reconciler error","varnish_controller_version":"undefined","reconciler group":"caching.ibm.com","reconciler kind":"VarnishCluster","name":"vc-sun-location-services-varnish-0","namespace":"sun-location-services","error":"Can't delete VCL config \"v-63207441-1618966417\": Command failed with error code 106\nNo VCL named v-63207441-1618966417 known.\n: exit status 1","errorVerbose":"exit status 1\nCommand failed with error code 106\nNo VCL named v-63207441-1618966417 known.\n\ngithub.com/ibm/varnish-operator/pkg/varnishcontroller/varnishadm.(*VarnishAdm).Discard\n\t/go/src/github.com/ibm/varnish-operator/pkg/varnishcontroller/varnishadm/varnishadm.go:145\ngithub.com/ibm/varnish-operator/pkg/varnishcontroller/controller.(*ReconcileVarnish).reconcileVarnish\n\t/go/src/github.com/ibm/varnish-operator/pkg/varnishcontroller/controller/controller_varnish.go:61\ngithub.com/ibm/varnish-operator/pkg/varnishcontroller/controller.(*ReconcileVarnish).reconcileWithContext\n\t/go/src/github.com/ibm/varnish-operator/pkg/varnishcontroller/controller/controller.go:192\ngithub.com/ibm/varnish-operator/pkg/varnishcontroller/controller.(*ReconcileVarnish).Reconcile\n\t/go/src/github.com/ibm/varnish-operator/pkg/varnishcontroller/controller/controller.go:109\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.8.2/pkg/internal/controller/controller.go:297\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.8.2/pkg/internal/controller/controller.go:252\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func1.2\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.8.2/pkg/internal/controller/controller.go:215\nk8s.io/apimachinery/pkg/util/wait.JitterUntilWithContext.func1\n\t/go/pkg/mod/k8s.io/apimachinery@v0.20.4/pkg/util/wait/wait.go:185\nk8s.io/apimachinery/pkg/util/wait.BackoffUntil.func1\n\t/go/pkg/mod/k8s.io/apimachinery@v0.20.4/pkg/util/wait/wait.go:155\nk8s.io/apimachinery/pkg/util/wait.BackoffUntil\n\t/go/pkg/mod/k8s.io/apimachinery@v0.20.4/pkg/util/wait/wait.go:156\nk8s.io/apimachinery/pkg/util/wait.JitterUntil\n\t/go/pkg/mod/k8s.io/apimachinery@v0.20.4/pkg/util/wait/wait.go:133\nk8s.io/apimachinery/pkg/util/wait.JitterUntilWithContext\n\t/go/pkg/mod/k8s.io/apimachinery@v0.20.4/pkg/util/wait/wait.go:185\nk8s.io/apimachinery/pkg/util/wait.UntilWithContext\n\t/go/pkg/mod/k8s.io/apimachinery@v0.20.4/pkg/util/wait/wait.go:99\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_amd64.s:1374\nCan't delete VCL config \"v-63207441-1618966417\"\ngithub.com/ibm/varnish-operator/pkg/varnishcontroller/controller.(*ReconcileVarnish).reconcileVarnish\n\t/go/src/github.com/ibm/varnish-operator/pkg/varnishcontroller/controller/controller_varnish.go:63\ngithub.com/ibm/varnish-operator/pkg/varnishcontroller/controller.(*ReconcileVarnish).reconcileWithContext\n\t/go/src/github.com/ibm/varnish-operator/pkg/varnishcontroller/controller/controller.go:192\ngithub.com/ibm/varnish-operator/pkg/varnishcontroller/controller.(*ReconcileVarnish).Reconcile\n\t/go/src/github.com/ibm/varnish-operator/pkg/varnishcontroller/controller/controller.go:109\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.8.2/pkg/internal/controller/controller.go:297\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.8.2/pkg/internal/controller/controller.go:252\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func1.2\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.8.2/pkg/internal/controller/controller.go:215\nk8s.io/apimachinery/pkg/util/wait.JitterUntilWithContext.func1\n\t/go/pkg/mod/k8s.io/apimachinery@v0.20.4/pkg/util/wait/wait.go:185\nk8s.io/apimachinery/pkg/util/wait.BackoffUntil.func1\n\t/go/pkg/mod/k8s.io/apimachinery@v0.20.4/pkg/util/wait/wait.go:155\nk8s.io/apimachinery/pkg/util/wait.BackoffUntil\n\t/go/pkg/mod/k8s.io/apimachinery@v0.20.4/pkg/util/wait/wait.go:156\nk8s.io/apimachinery/pkg/util/wait.JitterUntil\n\t/go/pkg/mod/k8s.io/apimachinery@v0.20.4/pkg/util/wait/wait.go:133\nk8s.io/apimachinery/pkg/util/wait.JitterUntilWithContext\n\t/go/pkg/mod/k8s.io/apimachinery@v0.20.4/pkg/util/wait/wait.go:185\nk8s.io/apimachinery/pkg/util/wait.UntilWithContext\n\t/go/pkg/mod/k8s.io/apimachinery@v0.20.4/pkg/util/wait/wait.go:99\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_amd64.s:1374\ngithub.com/ibm/varnish-operator/pkg/varnishcontroller/controller.(*ReconcileVarnish).reconcileWithContext\n\t/go/src/github.com/ibm/varnish-operator/pkg/varnishcontroller/controller/controller.go:193\ngithub.com/ibm/varnish-operator/pkg/varnishcontroller/controller.(*ReconcileVarnish).Reconcile\n\t/go/src/github.com/ibm/varnish-operator/pkg/varnishcontroller/controller/controller.go:109\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.8.2/pkg/internal/controller/controller.go:297\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.8.2/pkg/internal/controller/controller.go:252\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func1.2\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.8.2/pkg/internal/controller/controller.go:215\nk8s.io/apimachinery/pkg/util/wait.JitterUntilWithContext.func1\n\t/go/pkg/mod/k8s.io/apimachinery@v0.20.4/pkg/util/wait/wait.go:185\nk8s.io/apimachinery/pkg/util/wait.BackoffUntil.func1\n\t/go/pkg/mod/k8s.io/apimachinery@v0.20.4/pkg/util/wait/wait.go:155\nk8s.io/apimachinery/pkg/util/wait.BackoffUntil\n\t/go/pkg/mod/k8s.io/apimachinery@v0.20.4/pkg/util/wait/wait.go:156\nk8s.io/apimachinery/pkg/util/wait.JitterUntil\n\t/go/pkg/mod/k8s.io/apimachinery@v0.20.4/pkg/util/wait/wait.go:133\nk8s.io/apimachinery/pkg/util/wait.JitterUntilWithContext\n\t/go/pkg/mod/k8s.io/apimachinery@v0.20.4/pkg/util/wait/wait.go:185\nk8s.io/apimachinery/pkg/util/wait.UntilWithContext\n\t/go/pkg/mod/k8s.io/apimachinery@v0.20.4/pkg/util/wait/wait.go:99\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_amd64.s:1374"}
I'm not sure why v-63207441-1618966417 is erroring out as it's not showing up when i run vcl.list. Regardless I think we should just log these errors and proceed through discarding the rest of the inactive profiles.