hyperlinking build errors in console view does not work with local scons build cont
lokimon opened this issue · 6 comments
Could it be a search path thing? My project root is not the same as my workspace root.
If you would like, I can help troubleshoot.
I've downloaded your code, and have it in a separate workspace from my cdt project.
I'm not sure how to run a plugin from one instance of Eclipse into another though. If I could, I could watch it fire, and see where the issue is.
ok. so I figured out how to debug a plugin.
I think I still have some project mismatches between the master branch and the code that is on your deployment server, but it's probably close enough. some breakpoint steps go into comments, etc.
I am finding that in the findMember method of org.eclipse.core.internal.resources.Container, the local variable childpath is "/sc/ fatal error C1083: Cannot open include file: 'config/access/caAttrBool.h"
Here's a test that doesn't pass.
@test
public void compilerErrorPatternMatchWithWindowsPath2() {
Matcher m = PlatformSpecifics.CPP_RE.matcher("ioengine\DiskManager\dmDisk.cpp(50) : fatal error C1083: Cannot open include file: 'config/access/caAttrBool.h2");
assertTrue(m.find());
assertEquals("ioengine\DiskManager\dmDisk.cpp", m.group(1));
assertEquals("50", m.group(2));
}
Thanks for the unit test! I was able to reproduce this. One of the regex quantifiers in the hyperlinking code was too greedy. Just pushed a fix. Please update and retry.
New update seems to work. I think there is still an issue, where sometimes hyperlinking does not turn on. On initial thought it seemed to be that I had to clear the Console, otherwise hyperlinking started failing. I seemed like if one of the errors failed to hyperlinked (like with this too greedy issue) it wouldn't continue to try the others. But I can't be certain, as I now can't reproduce it. If I'm able to, I"ll open another issue. Hopefully with debug working, I will be able to help track it down as well.
Thanks for doing this. It really helps with cross platform projects. It's appreciated.