Igalia/vkrunner

Support probing multiple values in a probe command

jaebaek opened this issue · 3 comments

probe ssbo command forces us to use multiple commands even for a resource to check with multiple values.
See the following example.

[test]
ssbo 0 640
ssbo 1 subdata vec4 0 0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159

compute entrypoint foo
compute 40 1 1

probe ssbo vec4 0 0 == 3 1 2 0
probe ssbo vec4 0 16 == 7 5 6 4
probe ssbo vec4 0 32 == 11 9 10 8
probe ssbo vec4 0 48 == 15 13 14 12
probe ssbo vec4 0 64 == 19 17 18 16
probe ssbo vec4 0 80 == 23 21 22 20
probe ssbo vec4 0 96 == 27 25 26 24
probe ssbo vec4 0 112 == 31 29 30 28
probe ssbo vec4 0 128 == 35 33 34 32
probe ssbo vec4 0 144 == 39 37 38 36
probe ssbo vec4 0 160 == 43 41 42 40
probe ssbo vec4 0 176 == 47 45 46 44
probe ssbo vec4 0 192 == 51 49 50 48
probe ssbo vec4 0 208 == 55 53 54 52
probe ssbo vec4 0 224 == 59 57 58 56
probe ssbo vec4 0 240 == 63 61 62 60
probe ssbo vec4 0 256 == 67 65 66 64
probe ssbo vec4 0 272 == 71 69 70 68
probe ssbo vec4 0 288 == 75 73 74 72
probe ssbo vec4 0 304 == 79 77 78 76
probe ssbo vec4 0 320 == 83 81 82 80
probe ssbo vec4 0 336 == 87 85 86 84
probe ssbo vec4 0 352 == 91 89 90 88
probe ssbo vec4 0 368 == 95 93 94 92
probe ssbo vec4 0 384 == 99 97 98 96
probe ssbo vec4 0 400 == 103 101 102 100
probe ssbo vec4 0 416 == 107 105 106 104
probe ssbo vec4 0 432 == 111 109 110 108
probe ssbo vec4 0 448 == 115 113 114 112
probe ssbo vec4 0 464 == 119 117 118 116
probe ssbo vec4 0 480 == 123 121 122 120
probe ssbo vec4 0 496 == 127 125 126 124
probe ssbo vec4 0 512 == 131 129 130 128
probe ssbo vec4 0 528 == 135 133 134 132
probe ssbo vec4 0 544 == 139 137 138 136
probe ssbo vec4 0 560 == 143 141 142 140
probe ssbo vec4 0 576 == 147 145 146 144
probe ssbo vec4 0 592 == 151 149 150 148
probe ssbo vec4 0 608 == 155 153 154 152
probe ssbo vec4 0 624 == 159 157 158 156

If probe ssbo command allows us to check multiple values in a single command, it would be very helpful.

probe ssbo vec4 0 0 == 3 1 2 0 7 5 6 4 11 9 10 8 15 13 14 12 19 17 18 16 23 21 22 20 27 25 26 24 31 29 30 28 35 33 34 32 39 37 38 36 43 41 42 40 47 45 46 44 51 49 50 48 55 53 54 52 59 57 58 56 63 61 62 60 67 65 66 64 71 69 70 68 75 73 74 72 79 77 78 76 83 81 82 80 87 85 86 84 91 89 90 88 95 93 94 92 99 97 98 96 103 101 102 100 107 105 106 104 111 109 110 108 115 113 114 112 119 117 118 116 123 121 122 120 127 125 126 124 131 129 130 128 135 133 134 132 139 137 138 136 143 141 142 140 147 145 146 144 151 149 150 148 155 153 154 152 159 157 158 156
bpeel commented

This seems like a good idea to me.

bpeel commented

I made a pull request for this. #31

Thank you for working on it.
I will add reviews on the PR.