Several (non-breaking) Errors when updating Group Advantage.
TheFirst05 opened this issue · 4 comments
Versions
- Foundry VTT: v10.285
- WFRP4e System: 6.1.2
- GM Toolkit: 6.0.0
Description
What is happening
- Issue 1: When a player updates Group Advantage in combat, other players get a couple of errors. Group Advantage is still successfully modified.
To reproduce: Need 2 players logged in, with PC tokens in combat with an enemy token. Attempt to manually modify Group Advantage during combat.
- Issue 2: Furthermore, when combat is ended, the Group Advantage values in the combat tracker correctly gets set to 0, but the tokens on the scene still retain any remaining advantage. When the player then tries to manually reset their advantage (via the character sheet, for example), they get a little message saying they aren't allowed to modify Group Advantage out of combat, but fortunately(?) does not actually stop them from removing the remaining advantage.
Attempt to manually modify Group Advantage during combat.
By this in Issue 1, do you mean adjusting the Group Advantage fields in the Combat Tracker? If not, can you describe how it is manually adjusted please, eg, through their own character sheet, the Add Advantage macro, updating their Token Hud resource bar, etc ...
I believe Issue 2 is a WFRP4e issue. Certainly, this is a WFRP4e system notification message.
And this is the console log which points to the WFRP4e system file where the error is raised.
Looks like issue 1 may be related to switching between user and player accounts mid-combat testing. From a discussion with @TheFirst05 it's rare, and hasn't recurred in normal use, so the issue can be closed.