JalfResi/justext

JusText dies fatally when a paragraph is not found in the HTML

jonathaningram opened this issue · 3 comments

jonathaningram commented

At this line, https://github.com/JalfResi/justext/blob/master/reader.go#L57, a fatal error is logged but this causes the program to die with exit status 1.

Here is the output:

2013/07/24 19:28:39 <html><body></body></html>
2013/07/24 19:28:39 MAIN: P is nil<nil>
exit status 1

So looks like it's because a basic HTML file is sent in with no other elements.

JalfResi commented

Aw crap! Sorry! I'll try and find some time this weekend and sort this out,
or send me a pull request and I'll get it in ASAP.

Cheers,
Ben

On Thu, Jul 25, 2013 at 3:23 AM, Jonathan Ingram
notifications@github.comwrote:

At this line,
https://github.com/JalfResi/justext/blob/master/reader.go#L57, a fatal
error is logged but this causes the program to die with exit status 1.

Here is the output:

2013/07/24 19:28:39
2013/07/24 19:28:39 MAIN: P is nil
exit status 1

So looks like it's because a basic HTML file is sent in with no other
elements.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/20
.

jonathaningram commented

@JalfResi no probs. My colleague has sent a PR that should fix this #21

JalfResi commented

Fantastic, as I didn't get a chance to sort it out myself this weekend.
I've merged your colleagues fix into the master branch. Thanks for helping
to make GoJusText better!

Cheers,
Ben

On Mon, Jul 29, 2013 at 1:25 AM, Jonathan Ingram
notifications@github.comwrote:

@JalfResi https://github.com/JalfResi no probs. My colleague has sent a
PR that should fix this #21#21

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/20#issuecomment-21694405
.