Jeiwan/uniswapv3-code

Rounding problem

Opened this issue · 2 comments

m1s5 commented

https://github.com/Jeiwan/uniswapv3-code/blob/419fd1dd2aabc0bdbfe326ed34cc641934e49210/test/UniswapV3Pool.t.sol#L643C58-L643C75

Is not it some kind of an issue worth fixing? I think it is intolerable to burn money like that. As far as i get it nobody would be able to get them.

m1s5 commented

i think that if you have, say, 5 tokens and 2 participants the division should work like 2 | 3 and not 2 | 2 and 1 burned.

m1s5 commented

and, moreover, if this kind of a kink will be mirrored(not sure it's possible), the pool will not be able to work of insufficient tokens