Wanna merge and stuff?

Question

Wanna merge and stuff?

TylerBrinks opened this issue 4 years ago · 7 comments

Hi @HockeyJustin,

I've had occasion to resurrect ExCSS and I've done so incorporating all the work you've done to date. Are you interested in collaborating and unifying back to 1 repository & NuGet package? I have a handful of changes that are slated and it might make sense to ... "un-fork?" Whatever that means

Answer 1 · 2020-11-05T14:22:26.000Z

Hi @TylerBrinks.

Thanks for getting in touch.

Definitely happy to collaborate on unifying back to 1 repo. Sounds like you've done the hard work 😃.

Please let me know how you wish to proceed.

Answer 2 · 2020-11-05T20:35:36.000Z

Would it make sense to duplicate active issues to keep track of things?

Answer 3 · 2020-11-06T16:51:16.000Z

I didn't realise how time has flown! Thought I was keeping this thing up to date!

There are a couple of outstanding issues 13, 15....

and a couple of fairly simple looking PR's 11, 14.

We could duplicate them, but if it's easier, I can try to bash through them over the next week or so to clear this repo, then you can merge that in if you're happy with it? Can't guarantee a timeline at the moment as work is crazy, but I'm hoping next week will be ok.

.NET 5 should be shipping soon - either 10th or 22nd at .NET Conf. Will make sure it works on that too.

Answer 4 · 2020-11-06T18:30:12.000Z

Fantastic on all fronts! Thanks again!

…

________________________________ From: Justin <notifications@github.com> Sent: Friday, November 6, 2020 9:51 AM To: HockeyJustin/ExCSS_Core <ExCSS_Core@noreply.github.com> Cc: Tyler Brinks <tylerbrinks@hotmail.com>; Mention <mention@noreply.github.com> Subject: Re: [HockeyJustin/ExCSS_Core] Wanna merge and stuff? (#16) I didn't realise how time has flown! Thought I was keeping this thing up to date! There are a couple of outstanding issues 13<#13>, 15<#15>.... and a couple of fairly simple looking PR's 11<#11>, 14<#14>. We could duplicate them, but if it's easier, I can try to bash through them over the next week or so to clear this repo, then you can merge that in if you're happy with it? Can't guarantee a timeline at the moment as work is crazy, but I'm hoping next week will be ok. .NET 5 should be shipping soon - either 10th or 22nd at .NET Conf<https://www.dotnetconf.net/>. Will make sure it works on that too. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#16 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAA5YSTFVBXM4RAXEEVSGT3SOQSRJANCNFSM4TKYS63A>.

Answer 5 · 2020-11-25T08:53:48.000Z

Sorry. I haven't forgotten about this. Working long days at the moment. Will definitely get onto it soon though.

Answer 6 · 2020-11-28T11:34:47.000Z

@TylerBrinks - I have put a deprecation notice on ExCSS_Core, with reference to your new updated package.

I had a look at your latest updates and it seems to include everything required. I see you've even updated for net5.0.

Is there anything else reqiured here, or can we close this (and ExCSS_Core)?

Answer 7 · 2020-11-29T00:12:41.000Z

Thanks a ton! I think that's good to go at this point.