Proposal for some .cfg based fixes
Opened this issue · 5 comments
Some fixes for your consideration:
Missing stock agencies: there are 2 agencies in the base game without AGENCY nodes or logos (Light Year Tire Company + Stratus Corporation). These agencies are listed as the manufacturers of several parts each. When part test contracts are offered the system seems to prefer using the manufacturer as the agency providing the contract and with these parts it's unable to do so. A while ago I contacted the author of Kerbalized Flags who provided some great logos for them and gave permission to do whatever with them.
Another widely mentioned agency is Clamp-O-Tron, it's not listed as a manufacturer (aside from the radial attachment port being found behind their factory) but I think everyone is familiar with their docking ports.
When trying to complete all agency and manufacturer fields I found one was missing for the parachutes, so I asked the logo author if they wanted to make another one and they came up with Free Fall Parachutes. This one would be the most out of scope since it's not mentioned anywhere in the base game but it's still worth including here.
All these are included in a mod I'm working on (linked above) but I think they'd be more suited to this project, particularly with the logos being community-sourced.
Inconsistent/missing part manufacturers: Several parts have inconsistent and missing manufacturer values, this is an easy fix and if using the added agencies above almost every part's manufacturer can be a named agency.
There's room to debate who should manufacture the Flea and Hammer boosters, the winglet and the service bays so my choices there could be changed.
Inaccurate bulkhead profiles: A lot of parts have inaccurate bulkhead profile values (mostly surface attach parts), also mk0 and mk1 profiles are missing if these are considered to be separate from size0 and size1. The linked file contains fixes for these. The mk0 and mk1 fixes may be unsuitable given that the base game's only use for this field seems to be the editor sorting list, and mk0 + mk1 profiles would be missing icons, so you may only want the surface attach fixes here.
Let me know if you want any of these and I can do up a pull request and remove them from my mod.
Forgot to add one more:
Stock contracts fixes: A few parts test contracts are missing for the small rover wheel, smaller SRBs and MonoProp engine. In the linked file I also added some extra situations for a few contracts that seemed suitable along with surveys for the Magnetometer, Mystery Goo and Materials Bay.
On the surface, I'm not against config patches as long as they are purely cosmetic or are fixing a really problematic issue.
The stock agencies and missing part manufacturers feel fine to include. Bulkhead profiles are only used for editor part categories, so fine for me, but I concur that using non-existent stock categories (mk0 / mk1 ?) should be be avoided.
The contract patches are leaning a bit too much on the "new features" side to my taste.
This is a Pandora's box that I would prefer to stay closed. There are thousands of ways to make stock configs "better" and as many different opinions as to what changes are actually "better". And I have done enough KSP modding to know that maintaining stock-altering configs is a nightmare when you take the whole modding ecosystem into account.
Another note : please don't use wildcards and use discrete part names everywhere. You never know which random modded part you will accidentally target.
A PR is welcome if you agree to all of this :)
Ok, I'll put that together shortly
Did you have any preference for the directory structure? I can't see any other similar types of fixes so I guess a new folder labelled "Configs" with all this stuff inside, maybe with another subdirectory for the logos
There is currently a Patches directory for mod support patches. I would suggest renaming it ModSupportPatches, and creating a StockConfigsPatches next to it, with an Icons subfolder for the *.png files
thanks, submitted here #64