[Network] player_removed is not called for clients

Question

[Network] player_removed is not called for clients

yuraj11 opened this issue 4 years ago · 4 comments

player_added signal works fine and it's called on all clients but player_removed is called only on server.

Answer 1 · 2020-07-18T17:45:32.000Z

@yuraj11 are you using websockets and testing on smartphone browsers?

I noticed that websockets on iOS Safari aren't properl closed if the user leaves the website. Sometimes it takes up to 10 mins for godot to notice that the player has left.

Answer 2 · 2020-07-18T17:48:02.000Z

On desktop but there's implementation but it is commented in network.gd in function _on_player_disconnected for some reason.

Answer 3 · 2020-07-20T17:21:41.000Z

Is this still the case? I ask because 6192200 has changed the _on_player_disconnected and there is no commented "command" in it since that commit.

Answer 4 · 2020-07-20T17:50:36.000Z

Yeah sorry didn't see it. Works :)