KeithDHedger/KKEdit

Find/Replace All takes ages

Closed this issue · 7 comments

I think this happened in version 0.3.2:
When you perform Replace All in a large file, or rather for a large number of instances, the app window goes dark and (sometimes) it takes so long that you decide to quit.

Hi Sadi

Hadn't noticed this but I will check it out could you send me the file with the search terms you used, aslo are you using gtk2 or 3 version.
I have recently done a replace-all on all files on the kkedet source itself and didn't notice any problems, but these things do creep in.

Keith

Sent from Samsung tablet

-------- Original message --------
From: Sadi Yumuşak notifications@github.com
Date: 01/05/2016 11:47 (GMT+00:00)
To: KeithDHedger/KKEdit KKEdit@noreply.github.com
Subject: [KeithDHedger/KKEdit] Find/Replace All takes ages (#1)

I think this happened in version 0.3.2:
When you perform Replace All in a large file, or rather for a large number of instances, the app window goes dark and (sometimes) it takes so long that you decide to quit.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub

Hi Keith,
I use the new GTK3 version of KKEdit. I experience this issue for example when I try to replace all instances of 0.0.0.0 with 127.0.0.1 (or vice versa) in this file:
https://github.com/Sadi58/hostsblock/blob/master/indicator/hosts.txt

Until I can come up with a faster search/replace routine, try using a regex search with highlight all turned off, after the first 'find' the replace is practically instant, but this is a big file>400k with ove 15000 replacements, it is going to be slow, but I will see what I can do in the next few days.
Made quick couple of change's to the repos helps a bit.

Fixed, much, MUCH faster, caseless replace is somewhat slower but can't be helped, with the search/replace that Sadi used for case sensitive time is approx 5 secs for caseless is about 30 secs,

As a P.S. unfortunately this loses any bookmarks on theat page I will look at this next.

Wov, this is really fast; thanks a lot!
I'll close this first issue here then :-)

As always Sadi you're welcome.