Khan/react-components

Implementing "appear" in timeout transition group

Closed this issue · 5 comments

Hey guys,

Have you thought about adding the transitionAppear functionality to timeout-transition-group.jsx? Happy to send a PR if your interested.

As of React 0.14 you can (and should) specify timeouts directly on CSSTransitionGroup so TimeoutTransitionGroup isn't needed.

Is that component considered deprecated then?

In our case, we aren't ready to update to 14 and are using timeout groups.

On Friday, November 13, 2015, Ben Alpert notifications@github.com wrote:

Closed #49 #49.


Reply to this email directly or view it on GitHub
#49 (comment).

Best,
John Ong

@johnmanong yes, I'd consider this component deprecated. If you want to add transitionAppear to a fork and use that because you're on on React 0.14 yet, go for it! But that probably won't be merged upstream <3.

Sounds good! Thanks for the update!!

On Monday, November 16, 2015, Aria Buckles notifications@github.com wrote:

@johnmanong https://github.com/johnmanong yes, I'd consider this
component deprecated. If you want to add transitionAppear to a fork and
use that because you're on on React 0.14 yet, go for it! But that probably
won't be merged upstream <3.


Reply to this email directly or view it on GitHub
#49 (comment)
.

Best,
John Ong