Disabling a layer with `vk_loader_settings.json` and enabling if with `VK_INSTANCE_LAYERS` cause a crash

[christophe-lunarg]

The validation layer is turned off in vk_loader_settings.json and on with VK_INSTANCES_LAYER: Crash

Running vkcube log, including the env variables used:
log.txt

The loader settings:
vk_loader_settings.json

I think Vulkan Configurator should decide when it's on or off. When it's on auto, environment variables should take the lead.

[charles-lunarg]

Crash was due to the check that layers are already in the list not taking into account that 1. strcmp arguments must not be NULL and 2. that layers disabled by the loader settings file will not have some members filled out, causing false negatives. The fix is in the expanded_loader_settings_tests branch.

[christophe-lunarg]

This issue is resolved with today Vulkan-Loader main build