KirinJS/Kirin

Running npm run-script kirinkit

iwarner opened this issue · 10 comments

iwarner commented

Hi

Mac OS X ML

Running npm run-script kirinkit

I get

kirin@0.6.3 kirinkit /Users/ian.warner/node_modules/kirin
./bin/rebuild_kirinkit.sh

/Users/ian.warner/node_modules/kirin/node_modules/kirin-build/lib/node-modules.js:127
throw new Error(err);
^
Error: Cannot find a package.json file for kirin-build (from /Users/ian.warner/node_modules/kirin)
at NodeModule.discoverAll (/Users/ian.warner/node_modules/kirin/node_modules/kirin-build/lib/node-modules.js:127:19)
at Array.forEach (native)
at Function..each..forEach (/Users/ian.warner/node_modules/kirin/node_modules/underscore/underscore.js:79:11)
at Fileset.NodeModule.discoverAll (/Users/ian.warner/node_modules/kirin/node_modules/kirin-build/lib/node-modules.js:90:7)
at Object.exports.module (/Users/ian.warner/node_modules/kirin/node_modules/kirin-build/lib/node-modules.js:263:7)
at Object. (/Users/ian.warner/node_modules/kirin/node_modules/kirin-build/bin/kirin-build.js:109:41)
at Module._compile (module.js:449:26)
at Object.Module._extensions..js (module.js:467:10)
at Module.load (module.js:356:32)
at Function.Module._load (module.js:312:12)

jhugman commented

Sounds like you've installed from npm. I should publish an update to npm.
Could you confirm that by cloning from github then running npm install from
the install dir?

Many thanks

James
On 27 Oct 2012 15:04, "Ian Warner" notifications@github.com wrote:

Hi

Mac OS X ML

Running npm run-script kirinkit

I get

kirin@0.6.3 kirinkit /Users/ian.warner/node_modules/kirin
./bin/rebuild_kirinkit.sh

/Users/ian.warner/node_modules/kirin/node_modules/kirin-build/lib/node-modules.js:127
throw new Error(err);
^
Error: Cannot find a package.json file for kirin-build (from
/Users/ian.warner/node_modules/kirin)
at NodeModule.discoverAll
(/Users/ian.warner/node_modules/kirin/node_modules/kirin-build/lib/node-modules.js:127:19)
at Array.forEach (native)
at Function..each..forEach
(/Users/ian.warner/node_modules/kirin/node_modules/underscore/underscore.js:79:11)
at Fileset.NodeModule.discoverAll
(/Users/ian.warner/node_modules/kirin/node_modules/kirin-build/lib/node-modules.js:90:7)
at Object.exports.module
(/Users/ian.warner/node_modules/kirin/node_modules/kirin-build/lib/node-modules.js:263:7)
at Object.
(/Users/ian.warner/node_modules/kirin/node_modules/kirin-build/bin/kirin-build.js[image:
:109:]41)
at Module._compile (module.js:449:26)
at Object.Module._extensions..js (module.js:467:10)
at Module.load (module.js:356:32)
at Function.Module._load (module.js:312:12)

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/23.

jhugman commented

Fixed.

Problem was caused by change in dependency management.

Previously, the build script was looking at package.json/kirin/dependencies for dependencies. The newer version of this (that kirin depends upon) was doing this, but was the dependencies declared in this package were inconsistent with that behaviour.

Fixed, by pushing a newer version to npm. Thanks for reporting.

dhoskins commented

Still getting this when installing from NPM.

On 2 November 2012 03:43, jhugman notifications@github.com wrote:

Fixed.

Problem was caused by change in dependency management.

Previously, the build script was looking at
package.json/kirin/dependencies for dependencies. The newer version of this
(that kirin depends upon) was doing this, but was the dependencies declared
in this package were inconsistent with that behaviour.

Fixed, by pushing a newer version to npm. Thanks for reporting.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/23#issuecomment-10004098.

qzaidi commented

Broken for me as well on MacOS

Goes looking for package.json in node_modules/kirin/lib/javascript and fails because there isn't any package.json there.

This happens whether I install from npm or directly from github.

jhugman commented

OK. Sorry. I thought this was fixed. Will fix as a priority.

Could you confirm that this is a fresh install?
On 6 Nov 2012 14:48, "Qasim Zaidi" notifications@github.com wrote:

Broken for me as well on MacOS

Goes looking for package.json in node_modules/kirin/lib/javascript and
fails because there isn't any package.json there.

This happens whether I install from npm or directly from github.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/23#issuecomment-10103817.

qzaidi commented

Yes - I just installed it from github master.

Turned on debug and got this

Looking for a package.json file for ./bin/.. at ./bin/..
Looking for a package.json file for underscore at /Users/qasim/Source/node_modules/kirin/node_modules/underscore/underscore.js
Looking for a package.json file for progenitor at /Users/qasim/Source/node_modules/kirin/node_modules/progenitor/lib/progenitor-prompts.js
Looking for a package.json file for optimist at /Users/qasim/Source/node_modules/kirin/node_modules/progenitor/node_modules/optimist/index.js
Looking for a package.json file for wordwrap at /Users/qasim/Source/node_modules/kirin/node_modules/progenitor/node_modules/optimist/node_modules/wordwrap/index.js
Looking for a package.json file for prompt at /Users/qasim/Source/node_modules/kirin/node_modules/progenitor/node_modules/prompt/lib/prompt.js
Looking for a package.json file for pkginfo at /Users/qasim/Source/node_modules/kirin/node_modules/progenitor/node_modules/prompt/node_modules/pkginfo/lib/pkginfo.js
Looking for a package.json file for read at /Users/qasim/Source/node_modules/kirin/node_modules/progenitor/node_modules/prompt/node_modules/read/lib/read.js
Looking for a package.json file for mute-stream at /Users/qasim/Source/node_modules/kirin/node_modules/progenitor/node_modules/prompt/node_modules/read/node_modules/mute-stream/mute.js
Looking for a package.json file for revalidator at /Users/qasim/Source/node_modules/kirin/node_modules/progenitor/node_modules/prompt/node_modules/revalidator/lib/revalidator.js
Looking for a package.json file for utile at /Users/qasim/Source/node_modules/kirin/node_modules/progenitor/node_modules/prompt/node_modules/utile/lib/index.js
Looking for a package.json file for async at /Users/qasim/Source/node_modules/kirin/node_modules/progenitor/node_modules/prompt/node_modules/utile/node_modules/async/index.js
Looking for a package.json file for deep-equal at /Users/qasim/Source/node_modules/kirin/node_modules/progenitor/node_modules/prompt/node_modules/utile/node_modules/deep-equal/index.js
Looking for a package.json file for i at /Users/qasim/Source/node_modules/kirin/node_modules/progenitor/node_modules/prompt/node_modules/utile/node_modules/i/lib/inflect.js
Looking for a package.json file for mkdirp at /Users/qasim/Source/node_modules/kirin/node_modules/progenitor/node_modules/prompt/node_modules/utile/node_modules/mkdirp/index.js
Looking for a package.json file for ncp at /Users/qasim/Source/node_modules/kirin/node_modules/progenitor/node_modules/prompt/node_modules/utile/node_modules/ncp/lib/ncp.js
Looking for a package.json file for rimraf at /Users/qasim/Source/node_modules/kirin/node_modules/progenitor/node_modules/prompt/node_modules/utile/node_modules/rimraf/rimraf.js
Looking for a package.json file for winston at /Users/qasim/Source/node_modules/kirin/node_modules/progenitor/node_modules/prompt/node_modules/winston/lib/winston.js
Looking for a package.json file for colors at /Users/qasim/Source/node_modules/kirin/node_modules/progenitor/node_modules/prompt/node_modules/winston/node_modules/colors/colors.js
Looking for a package.json file for cycle at /Users/qasim/Source/node_modules/kirin/node_modules/progenitor/node_modules/prompt/node_modules/winston/node_modules/cycle/cycle.js
Looking for a package.json file for eyes at /Users/qasim/Source/node_modules/kirin/node_modules/progenitor/node_modules/prompt/node_modules/winston/node_modules/eyes/lib/eyes.js
Looking for a package.json file for request at /Users/qasim/Source/node_modules/kirin/node_modules/progenitor/node_modules/prompt/node_modules/winston/node_modules/request/main.js
Looking for a package.json file for stack-trace at /Users/qasim/Source/node_modules/kirin/node_modules/progenitor/node_modules/prompt/node_modules/winston/node_modules/stack-trace/lib/stack-trace.js
/Users/qasim/Source/node_modules/kirin/node_modules/kirin-build/lib/node-modules.js:127
throw new Error(err);
^
Error: Cannot find a package.json file for kirin-build (from /Users/qasim/Source/node_modules/kirin)

jhugman commented

Thanks.

Strange that it should be crawling those dependencies at all.

I'm currently ooo, in transit, but will be able to have a look in the next
day or so.
On 6 Nov 2012 14:56, "Qasim Zaidi" notifications@github.com wrote:

Yes - I just installed it from github master.

Turned on debug and got this

Looking for a package.json file for ./bin/.. at ./bin/..
Looking for a package.json file for underscore at
/Users/qasim/Source/node_modules/kirin/node_modules/underscore/underscore.js
Looking for a package.json file for progenitor at
/Users/qasim/Source/node_modules/kirin/node_modules/progenitor/lib/progenitor-prompts.js
Looking for a package.json file for optimist at
/Users/qasim/Source/node_modules/kirin/node_modules/progenitor/node_modules/optimist/index.js
Looking for a package.json file for wordwrap at
/Users/qasim/Source/node_modules/kirin/node_modules/progenitor/node_modules/optimist/node_modules/wordwrap/index.js
Looking for a package.json file for prompt at
/Users/qasim/Source/node_modules/kirin/node_modules/progenitor/node_modules/prompt/lib/prompt.js
Looking for a package.json file for pkginfo at
/Users/qasim/Source/node_modules/kirin/node_modules/progenitor/node_modules/prompt/node_modules/pkginfo/lib/pkginfo.js
Looking for a package.json file for read at
/Users/qasim/Source/node_modules/kirin/node_modules/progenitor/node_modules/prompt/node_modules/read/lib/read.js
Looking for a package.json file for mute-stream at
/Users/qasim/Source/node_modules/kirin/node_modules/progenitor/node_modules/prompt/node_modules/read/node_modules/mute-stream/mute.js
Looking for a package.json file for revalidator at
/Users/qasim/Source/node_modules/kirin/node_modules/progenitor/node_modules/prompt/node_modules/revalidator/lib/revalidator.js
Looking for a package.json file for utile at
/Users/qasim/Source/node_modules/kirin/node_modules/progenitor/node_modules/prompt/node_modules/utile/lib/index.js
Looking for a package.json file for async at
/Users/qasim/Source/node_modules/kirin/node_modules/progenitor/node_modules/prompt/node_modules/utile/node_modules/async/index.js
Looking for a package.json file for deep-equal at
/Users/qasim/Source/node_modules/kirin/node_modules/progenitor/node_modules/prompt/node_modules/utile/node_modules/deep-equal/index.js
Looking for a package.json file for i at
/Users/qasim/Source/node_modules/kirin/node_modules/progenitor/node_modules/prompt/node_modules/utile/node_modules/i/lib/inflect.js
Looking for a package.json file for mkdirp at
/Users/qasim/Source/node_modules/kirin/node_modules/progenitor/node_modules/prompt/node_modules/utile/node_modules/mkdirp/index.js
Looking for a package.json file for ncp at
/Users/qasim/Source/node_modules/kirin/node_modules/progenitor/node_modules/prompt/node_modules/utile/node_modules/ncp/lib/ncp.js
Looking for a package.json file for rimraf at
/Users/qasim/Source/node_modules/kirin/node_modules/progenitor/node_modules/prompt/node_modules/utile/node_modules/rimraf/rimraf.js
Looking for a package.json file for winston at
/Users/qasim/Source/node_modules/kirin/node_modules/progenitor/node_modules/prompt/node_modules/winston/lib/winston.js
Looking for a package.json file for colors at
/Users/qasim/Source/node_modules/kirin/node_modules/progenitor/node_modules/prompt/node_modules/winston/node_modules/colors/colors.js
Looking for a package.json file for cycle at
/Users/qasim/Source/node_modules/kirin/node_modules/progenitor/node_modules/prompt/node_modules/winston/node_modules/cycle/cycle.js
Looking for a package.json file for eyes at
/Users/qasim/Source/node_modules/kirin/node_modules/progenitor/node_modules/prompt/node_modules/winston/node_modules/eyes/lib/eyes.js
Looking for a package.json file for request at
/Users/qasim/Source/node_modules/kirin/node_modules/progenitor/node_modules/prompt/node_modules/winston/node_modules/request/main.js
Looking for a package.json file for stack-trace at
/Users/qasim/Source/node_modules/kirin/node_modules/progenitor/node_modules/prompt/node_modules/winston/node_modules/stack-trace/lib/stack-trace.js

/Users/qasim/Source/node_modules/kirin/node_modules/kirin-build/lib/node-modules.js:127
throw new Error(err);
^
Error: Cannot find a package.json file for kirin-build (from
/Users/qasim/Source/node_modules/kirin)

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/23#issuecomment-10103976.

jhugman commented

I think I have recreated this:

% npm install kirin 
% cd node_modules/kirin
% npm run-script kirinkit

Workaround: This method works, however:

% git clone git@github.com:KirinJS/Kirin.git
% cd Kirin
% npm install 
% npm run-script kirinkit

For the version published with npm, some processing of the package.json occurs which means that the optionalDependencies become dependencies. kirin-build uses the dependencies to work out what are to be included in the build. Since this smooshing together happens, it screws up what gets packaged.

The fix will be to either work out a way for kirin-build to determine the dependencies that need to be on the device. I expect that this will be something to do with subtracting the entries in dependencies from the entries in optionalDependencies.

qzaidi commented

Thanks - this worked for me.

jhugman commented

Fixed as described in the above comment.

The fix is implemented in kirin-build, so no need to push any new version of kirin to npm.