Slicer_VERSION versus APPLICATION_VERSION

[phcerdan]

SlicerCustomAppTemplate/{{cookiecutter.project_name}}/CMakeLists.txt

Lines 31 to 35 in 5d91a64

	set(APPLICATION_NAME "{{cookiecutter.project_name}}")
	set(Slicer_VERSION_MAJOR "0")
	set(Slicer_VERSION_MINOR "1")
	set(Slicer_VERSION_PATCH "0")
	project(${APPLICATION_NAME} VERSION "${Slicer_VERSION_MAJOR}.${Slicer_VERSION_MINOR}.${Slicer_VERSION_PATCH}")

Shouldn't that be?

set(APPLICATION_VERSION_MAJOR       "0") 
set(APPLICATION_VERSION_MINOR       "1") 
set(APPLICATION_VERSION_PATCH       "0") 
project(${APPLICATION_NAME} VERSION "${APPLICATION_VERSION_MAJOR}.${APPLICATION_VERSION_MINOR}.${APPLICATION_VERSION_PATCH}") 

Thanks!

[jcfr]

In the current Slicer, I don't think there any differentiation of version of the app and version of Slicer, this is currently being added .

[phcerdan]

Thanks @jcfr, that's great, but the name is then misleading, the SlicerSALT dev is not setting the Slicer_VERSION here.

this is currently being added. What do you mean? Is it local WIP, or is there any branch out-there?
Should I fix this in a PR or let it be waiting for your changes?
Thanks

[jcfr]

What do you mean? Is it local WIP, or is there any branch out-there?

Work in progress locally on my workstation.

I plan to push a topic for review by the end of the afternoon

[jcfr]

Closing. Duplicate of #3

[jcfr]

What do you mean? Is it local WIP, or is there any branch out-there?

See Slicer/Slicer#997