KristopherGBaker/Maaku

Suggest renaming `destination`, `url`, and `title`

Closed this issue · 3 comments

NightFlyer commented

I think it would be best to rename CMNode.destination, CMNode.url, and CMNode.title to better capture that these are all link/image related items. I would suggest linkDestination, linkUrl, and linkTitle.

At the very least, I would suggest changing title to linkTitle, as the word "title" makes it confusing.

NightFlyer commented

I'll do the work if you agree on the names, or suggest other names.

KristopherGBaker commented

Go ahead your suggested names. 👍

NightFlyer commented

I'm thinking that leaving Core/Link and Core/Image fields alone, since the type name is already a qualifier. The problem with those fields in CMNode is that they're available for all nodes and so it's confusing (why wouldn't a heading node have a title?). There isn't that confusion when you're actually looking at a type that specifies what the underlying info refers to.

  • 👍1