url method problem if internal link is null

Question

url method problem if internal link is null

frankar opened this issue 8 years ago · 2 comments

in MenuItem.php I suggest:

        case 'internal_link':
            return is_null($this->link) ? "#" : url($this->link);
            break;

because if the internal_link is not compiled when you render it, you has this error:
htmlspecialchars() expects parameter 1 to be string, object given

Answer 1 · 2017-04-05T12:27:52.000Z

Hi @frankar,

Thank, just pushed the fix.

Cheers!

Answer 2 · 2017-04-05T13:45:28.000Z

Great!! Il 05/apr/2017 14:27, "Cristian Tabacitu" <notifications@github.com> ha scritto:

…

Hi @frankar <https://github.com/frankar>, Thank, just pushed the fix. Cheers! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#13 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABMxwC8sNPbfF-bHhBEvbB0bV0eL8PKIks5rs4jIgaJpZM4KrsJO> .