Lightning-Universe/lightning-flash

Protobuf requirements too strict

nrudakov opened this issue · 5 comments

protobuf <=3.20.1 prevents using latest onnx version. Onnx requires protobuf >= 3.20.2
Is it possible to change protobuf requirements to protobuf < 4?

Borda commented

We would like to check this pining... as we resolved the CI, could you open PR with the suggestion of a higher version...
Note that this pin is just for CI not when you install the package:

# NOTE: all pins for latest are for CI consistency unless it is `strict`, then it is also forced in setup

I realize that you've already released v0.8.2 which relaxes the protobuf requirements entirely, but would it be possible to issue another .post version on 0.8.1 that relaxes the protobuf requirements to at least <4, since I need a version that can work with lightning-utilities 0.3.0, and 0.8.2 needs lightning-utilities >=0.4.1.

Also, in addition to onnx needing protobuf >=3.20.2, google-api-core >=2.10.2 doesn't work with protobuf 3.20.0 or 3.20.1.

Borda commented

I am afraid we would be able to validate correctness for 0.8.1.post unless we include almost all patches with 0.8.2 🤔 what is preventing you from using the latest bug-fix release?

I have another package that I can't upgrade because its newer version would require lightning >=2, and so the version I have to use needs lightning-utilities 0.3.0 only.

Admittedly, if this package and lightning-bolts were to support lightning >=2, then I could update all of the packages.

Actually, I must have misread something, as the protobuf requirements in requirements/base.txt for version 0.8.2 are still protobuf <= 3.20.1