Parent status link bugs - No1 "Switch Parent – connection lost"
LangNerd23 opened this issue · 5 comments
Description
When the parent for a term is switched to a new one, the parent link status gets lost after(!) saving.
(Maybe related to „parent status link bugs – No2“ that I will post in a second)
To Reproduce
- Choose a term that has had already one parent up to that point (with status_link yes)
- Go into edit mode
- Delete existing parent and choose a new one from drop down list (not 100% sure if that part is necessary for reproducing the error)
- After having picked the new parent the box status_link had been automatically checked
- Save
- Enter again edit mode of the term from before
- In >90% of the cases the checkbox of „link to parent“ is empty
Extra software info, if not already included in the Description:
- OS: Windows
- Browser: Checked both with Chrome and Firefox
- How you've installed Lute (Docker, python, source): via pip, Version 3.3.2 (couldn’t check with 3.3.3 for the reasons given on discord)
Confirmed, thanks. On the develop branch:
existing term with existing parent, link is set
delete that parent, link removed:
select new parent, link is set on the form (before save):
After save and reopen, the checkbox was cleared (it shouldn't have been):
Thanks again @LangNerd23 -- Lute was doing too much cleanup when the old parent was getting removed from the record. Currently working on this, have an initial fix, and hope to have it sorted out soon. -- edit, spoke too soon, the fix isn't quite right. Tricky!
Have a fix for this now, the link is maintained even on parent change. e.g. repeating the above example:
Fix merged into develop, will be in next launch.
Hi @LangNerd23 -- I believe that this has been fixed with the launch of 3.4.3 (just now). I'll close this issue -- please re-open a new one if you run into more problems with this, and reference this if needed. Cheers and thanks!