Lyall/IshinFix

Cutscenes still running at 30fps

Tataru-Taru opened this issue · 3 comments

Perhaps I am missing something obvious, but I think I've done everything right. But the main cutscenes are stuck at 30fps when I try loading up a game.

Log

 date       time         ( uptime  ) [ thread name/id ]                   file:line     v| 
 2023-02-23 18:40:31.145 (   0.001s) [        55746F0E]             loguru.cpp:841   INFO| Logging to 'IshinFix.log', mode: 'w', verbosity: 9
 2023-02-23 18:40:31.147 (   0.001s) [Main            ]            dllmain.cpp:166   INFO| IshinFix v1.0.3 loaded
 2023-02-23 18:40:31.147 (   0.002s) [Main            ]            dllmain.cpp:196   INFO| Game Name: Like a Dragon: Ishin!
 2023-02-23 18:40:31.147 (   0.002s) [Main            ]            dllmain.cpp:197   INFO| Game Path: C:\Program Files (x86)\Steam\steamapps\common\LikeADragonIshin\LikeaDragonIshin\Binaries\Win64\LikeaDragonIshin-Win64-Shipping.exe
 2023-02-23 18:40:31.148 (   0.002s) [Main            ]            dllmain.cpp:219   INFO| Config Parse: iInjectionDelay: 1000ms
 2023-02-23 18:40:31.148 (   0.002s) [Main            ]            dllmain.cpp:220   INFO| Config Parse: bAspectFix: 0
 2023-02-23 18:40:31.148 (   0.002s) [Main            ]            dllmain.cpp:221   INFO| Config Parse: bFOVFix: 1
 2023-02-23 18:40:31.148 (   0.002s) [Main            ]            dllmain.cpp:222   INFO| Config Parse: fAdditionalFOV: 0.00
 2023-02-23 18:40:31.148 (   0.002s) [Main            ]            dllmain.cpp:223   INFO| Config Parse: bCutsceneFPS: 1
 2023-02-23 18:40:31.148 (   0.002s) [Main            ]            dllmain.cpp:224   INFO| Config Parse: iCustomResX: 2560
 2023-02-23 18:40:31.148 (   0.002s) [Main            ]            dllmain.cpp:225   INFO| Config Parse: iCustomResY: 1440
 2023-02-23 18:40:31.148 (   0.002s) [Main            ]            dllmain.cpp:226   INFO| Config Parse: fNewX: 2560.00
 2023-02-23 18:40:31.148 (   0.002s) [Main            ]            dllmain.cpp:227   INFO| Config Parse: fNewY: 1440.00
 2023-02-23 18:40:31.148 (   0.002s) [Main            ]            dllmain.cpp:228   INFO| Config Parse: fNewAspect: 1.7778
 2023-02-23 18:40:32.190 (   1.044s) [Main            ]            dllmain.cpp:323   INFO| FOV Culling: Hook length is 16 bytes
 2023-02-23 18:40:32.190 (   1.044s) [Main            ]            dllmain.cpp:324   INFO| FOV Culling: Hook address is 0x14372bdb0
 2023-02-23 18:40:32.197 (   1.052s) [Main            ]            dllmain.cpp:342   INFO| CutsceneFPS: Patched byte(s) at 0x140bc8085

Install Path
C:\Program Files (x86)\Steam\steamapps\common\LikeADragonIshin\LikeaDragonIshin\Binaries\Win64

Ini File

; Injection delay in milliseconds.
InjectionDelay = 1000

;;;;;;;;;; Fixes ;;;;;;;;;;

[Fix Aspect Ratio]
; Fixes aspect ratio and removes pillarboxing/letterboxing.
Enabled = True

[Fix FOV]
; Corrects vert- FOV
; Can add additional FOV
Enabled = true
AdditionalFOV = 0

;;;;;;;;;; General ;;;;;;;;;;

[Remove Cutscene FPS Cap]
; Uncaps 30fps cutscenes.
Enabled = true
Lyall commented

Your log looks good so I'm not 100% sure why it's not working. I did just modify this part of the fix to address it uncapping the FPS during minigames so it could well be an issue with that.

Just to narrow things down, can you try running one of the cutscenes from the "Replay" menu in the main title screen. During my testing I only tested Chapter 1 Cutscene 4 from this menu and one during gameplay. It could be that other cutscenes have a different piece of code responsible for capping the framerate.

I think I found the issue, the video was the first video of a chapter, seems the recaps aren't in engine, but actual videos.

That's my bad, all the other ones are running at 60fps. Hadn't considered the recap videos aren't in engine.

Lyall commented

Good to hear it's working for you! I'll close the issue now.