Support for Pandas 2.0?
Closed this issue · 7 comments
Hello, currently, Pandas is pinned to version 1.x:
Line 16 in 4d4233f
Meanwhile, Pandas 2.0 has been released, and trying to install it alongside wfdb logically leads to a dependency conflict.
I wanted to ask if wfdb is supposed to not work with Pandas 2.0 now or if the version pinning is unnecessarily restrictive and could be relaxed to include Pandas 2.0 as well?
Thanks,
Richard
I ran the tests with pandas 2.0.0 and they all pass. Please let me know if you would like me to submit a PR.
FWIW, capping dependencies are usually not ideal, so if possible please consider removing all upper bounds from your dependencies (see e.g. https://iscinumpy.dev/post/bound-version-constraints/#tldr for an explanation).
Thanks for looking at this @cbrnr.
Please let me know if you would like me to submit a PR.
Yes, please, I'd appreciate it. Thanks!
FWIW, capping dependencies are usually not ideal, so if possible please consider removing all upper bounds from your dependencies (see e.g. https://iscinumpy.dev/post/bound-version-constraints/#tldr for an explanation).
I hadn't realised that the ^ was adding an upper bound, but I now see that it is. I don't think there's any reason why we want to be fixing ourselves on these old versions (certainly not for pandas, at least).
@bemoody any reasons why we shouldn't remove all of the upper bounds in pyproject.toml as suggested? Seems like a good idea to me. @cbrnr if you have time, please also feel free to open a (separate) PR for this.
Great! @tompollard Any chance of tagging a new release with this change?
@hoechenberger sure, we'll do this shortly. @bemoody has been managing the updates recently. Benjamin, okay with making a new release? Let me know if you'd like me to take care of it. It would be good if we could merge #448 beforehand too.
@hoechenberger Done! See: https://pypi.org/project/wfdb/4.1.1/
pip install wfdb --upgrade should bump you to the latest version.
Thank you!