[VCU] TRANSITION_FATAL comes before TRANSITION_RECOVERABLE

[sebLopezCot]

In state_error.c we have

void update_no_error_state(void) {
TRANSITION_FATAL();
TRANSITION_RECOVERABLE();
}

this is bad because if we reach both a fatal and a recoverable error, the state transition will happen to recoverable before the update loop body of the fatal transition will occur. This will result in not disabling the motors and closing contactors.

[nistath]

k just add a return 7 Απρ 2018, 14:12, ο χρήστης «Sebastian Lopez-Cot <notifications@github.com<mailto:notifications@github.com>>» έγραψε: In state_error.c we have void update_no_error_state(void) { TRANSITION_FATAL(); TRANSITION_RECOVERABLE(); } this is bad because if we reach both a fatal and a recoverable error, the state transition will happen to recoverable before the update loop body of the fatal transition will occur. This will result in not disabling the motors and closing contactors. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<#9>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AMt2Y8-uS9CvSJE9Umhjk94BZ5MwgcaCks5tmQGGgaJpZM4TLMGP>.