MRCIEU/gwasglue2

merge? length? etc

explodecomputer opened this issue · 0 comments

I just wonder if it's worth using some generic R function names for some of the dataset manipulation functions e.g.

  • merge could be used to merge either two datasets into one, a list of summarysets into a dataset, a list of summarysets and datasets - that could make life quite a lot easier for analysts. This would replace create_dataset and add_summaryset (or just be a wrapper around those existing methods)
  • perhaps just use length instead of getLength

I like how you can just do dataset[c(1,2,5)] and it selects the summarysets that way