MagicStack/uvloop

`__init__.pyi` added on #570 breaks mypy

vkottler opened this issue · 6 comments

vkottler commented
  • uvloop version: 0.18.0
  • Python version: 3.11.4
  • Platform: Linux (Ubuntu)
  • Can you reproduce the bug with PYTHONASYNCIODEBUG in env?: N/A
  • Does uvloop behave differently from vanilla asyncio? How?: N/A
vkottler at vkottler-tower in ~/src/vkottler/vcorelib (dev/3.0.1)
$ ./venv/bin/mypy tests vcorelib setup.py tasks
vcorelib/asyncio/__init__.py:205: error: Module has no attribute "new_event_loop"  [attr-defined]
vcorelib/asyncio/__init__.py:209: error: Module has no attribute "install"  [attr-defined]
Found 2 errors in 1 file (checked 154 source files)

This appears to be caused by the addition of this file: https://github.com/MagicStack/uvloop/blob/master/uvloop/__init__.pyi.

It does not contain any information about e.g. __all__ defined in init.py.

edit: also reproduces in GitHub Actions

vkottler commented

For my situation, I can just revert this commit: vkottler/vcorelib@81a1ba3 if/when there's a fix.

fantix commented

I believe #573 shall fix this issue.

  • ❤️1
Kludex commented

Is a release expected to happen soon?

  • ❤️3
graingert commented

@fantix can you cut a release with this fix in? it's blocking CI on uvicorn.

If you're busy that's ok just let me know and I'll depend on the git HEAD in uvicorn

  • 👀1
fantix commented

Yeah sure - I'll try to include some more stuff and cut a release this weekend.

  • 👍1
danking commented

Thanks @fantix ! I think we can now close this issue.

https://github.com/MagicStack/uvloop/releases/tag/v0.19.0

  • ❤️1