GitHub action to get the latest mapml-viewer
prushforth opened this issue · 2 comments
When a push comes to this repo on a particular branch perhaps not main, but maybe mapml, the latest version of the mapml-viewer build should be integrated into the mapml extension in the specific branch.
An issue would be that the upstream project requires PRs to be in the form of single commits, but if we add a commit on push here, we would need to auto squash that commit with other commits that were pushed before it, although squashing commits could be outside the scope of the required action. Typically I do that manually just prior to submitting the PR.
Another issue is that the latest mapml-viewer doesn't exist on the web-map-custom-element repo, it needs to be built, which maybe isn't a big deal since this is an action and that's what they do. i.e. the action could pull the latest and build locally.
Finally, another issue is that each file in the viewer has a custom license header, which would need to be obtained from somewhere when merging because it is obliged to be part of files included in GeoServer. @ahmadayubi can you respond on how you think this might be done or if it's too much trouble?
Thanks
All those issues can be handled except for the last involving adding a custom license header to each file. It's probably not impossible but would definitely be a custom action as in a custom .sh script file, assuming there's a command for editing files in a terminal.
A reference for a custom action is the sync-repo action found here: https://github.com/Maps4HTML/Web-Map-Custom-Element/tree/master/.github/actions/sync-repo