Reprap Discount Full Graphics Smart Controller Display is Garbled

Question

Reprap Discount Full Graphics Smart Controller Display is Garbled

dcwalmsley opened this issue 6 years ago · 37 comments

So here I am again.

Downloaded the latest 1.1.9 bugfix since the my last 1.1.8 bugfix release and developed an issue that has been an annoyance for me and I'm sure for some with Reprap Discount Full Graphics Smart Controller Display coming up garbled after flashing firmware. My LCD is the red version (12864) of the Reprap boards.

I've attached two images of the LCD display and the zipped folder of my modifications to your latest BugFix.

My printer is a HyperCube using a Einsy Rambo board.
I'm also using U8glib 1.18.0 currently and have tried 1.19.1 with no success on either library.
The compiler I'm using is an Arduino 1.8.7 program.

Marlin-1.1.9 Release 10-3-2018.zip

Did I miss something in updating the firmware?

Appreciate all that you great folks do and look forward to some help fixing this problem.

Best Regards,
Doug Walmsley

Answer 1 · 2018-10-04T15:41:38.000Z

You have the connector on the display in the wrong orientation, you need to pry the two plastic connector off on the display and rotate them 180 degrees. That'll fix your problem.

Answer 2 · 2018-10-04T15:48:51.000Z

Thanks for the insight but that was done back in build 1.1.8 and it worked as you described. So there should be no difference now that I I have upgraded to the latest version. This is a firmware issue.

Answer 3 · 2018-10-04T15:53:25.000Z

Ok, then you need to add a condition to ultralcd_st7920_u8glib_rrd.h
locate line 56 and make sure it reads:

#elif MB(MINIRAMBO) || MB(EINSY_RAMBO)

Answer 4 · 2018-10-04T18:00:42.000Z

Looks like a timing problem. Not like a connection problem. Increase delays.

Answer 5 · 2018-10-04T20:41:26.000Z

@larsnordstrom

Thanks! That addition fixed my issue.

Answer 6 · 2018-11-09T08:50:33.000Z

@larsnordstrom

How did you solve it?
I have the same problem with a tornado and marlin 1.1.9 & mks_gen_L.

I define in config.h, as I understood,but it still does not work, it looks fuzzy. What do I do wrong?

#define ST7920_DELAY_1 DELAY_NS(0)
#define ST7920_DELAY_2 DELAY_NS(250)
#define ST7920_DELAY_3 DELAY_NS(0)

say that in 1.1.8 the configuration was as follows.

#define ST7920_DELAY_1 DELAY_0_NOP
#define ST7920_DELAY_2 DELAY_3_NOP
#define ST7920_DELAY_3 DELAY_0_NOP

Forgive my english... heheheh

Answer 7 · 2018-11-09T11:29:35.000Z

Try some longer delays, for example:

#define ST7920_DELAY_1 DELAY_NS(250)
#define ST7920_DELAY_2 DELAY_NS(250)
#define ST7920_DELAY_3 DELAY_NS(250)

Answer 8 · 2018-11-09T11:33:57.000Z

Thanks, I have already achieved it.

#define ST7920_DELAY_1 DELAY_NS (0)
#define ST7920_DELAY_2 DELAY_NS (400)
#define ST7920_DELAY_3 DELAY_NS (0)

I went up from 50 in 50 until the problem was corrected.

Likewise, thank you very much.

Answer 9 · 2019-10-09T17:47:48.000Z

@thinkyhead &
@AnHardt

i just wanted to say a BIG thanks to you both, the delay setting also worked for me using MEGA2560/RAMPS/RRD Full Graphic Smart Controller (with buzzer, STOP Button, POT & Encoder, RED PCB By www.robotlinking.com)

Racking my brain over this for days lol

Thanks LOADS guys, really grateful !

Answer 10 · 2019-10-19T20:35:47.000Z

the lines
#define ST7920_DELAY_1 DELAY_NS (0)
#define ST7920_DELAY_2 DELAY_NS (400)
#define ST7920_DELAY_3 DELAY_NS (0)

were do you put them at?

Answer 11 · 2019-10-21T05:06:00.000Z

the lines
#define ST7920_DELAY_1 DELAY_NS (0)
#define ST7920_DELAY_2 DELAY_NS (400)
#define ST7920_DELAY_3 DELAY_NS (0)

were do you put them at?

From post above by larsnordstrom
Ok, then you need to add a condition to ultralcd_st7920_u8glib_rrd.h
locate line 56 and make sure it reads:

#elif MB(MINIRAMBO) || MB(EINSY_RAMBO)

You'll find that line already there and the 3 lines you refer to are 57, 58 and 59

Answer 12 · 2019-10-21T18:38:36.000Z

the lines
#define ST7920_DELAY_1 DELAY_NS (0)
#define ST7920_DELAY_2 DELAY_NS (400)
#define ST7920_DELAY_3 DELAY_NS (0)
were do you put them at?

From post above by larsnordstrom
Ok, then you need to add a condition to ultralcd_st7920_u8glib_rrd.h
locate line 56 and make sure it reads:

#elif MB(MINIRAMBO) || MB(EINSY_RAMBO)

You'll find that line already there and the 3 lines you refer to are 57, 58 and 59

i have the same problem but i have an ramps 1.4 borad,where do i change the delay)?

Answer 13 · 2019-10-21T23:12:08.000Z

i have the same problem but i have an ramps 1.4 borad,where do i change the delay)?

If you want you can define your own set of delays in Configuration.h.

Answer 14 · 2019-10-22T06:01:25.000Z

Hi again.
I searched in config.h and I didn't find such an comment I could change but I went back into (ultralcd_st7920_u8glib_rrd.h)tab
And there is 3 lines where it says you can define your own.
I changed mine to:
#define ST7920_DELAY_1 DELAY_NS (0)
#define ST7920_DELAY_2 DELAY_NS (400)
#define ST7920_DELAY_3 DELAY_NS (0)

And everything works fine now.big thanks from me anyway

Answer 15 · 2019-10-22T06:35:03.000Z

i found them lines and changed them to what is here but i seen no change to the screen. can some one define what each of the 3 lines do?

…

On Oct 22, 2019 at 2:02 AM, darap89 ***@***.***> wrote: Hi again. I searched in config.h and I didn't find such an comment I could change but I went back into (ultralcd_st7920_u8glib_rrd.h)tab And there is 3 lines where it says you can define your own. I changed mine to: #define ST7920_DELAY_1 DELAY_NS (0) #define ST7920_DELAY_2 DELAY_NS (400) #define ST7920_DELAY_3 DELAY_NS (0) And everything works fine now.big thanks from me anyway — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

Answer 16 · 2019-10-22T06:59:16.000Z

@gazehound
I can't explain it right as my English isn't that good but did you remember to uncommint the 3 lines after you have changed the numbers

Answer 17 · 2019-10-22T07:04:36.000Z

yes i did remembered to do this time :). just tring to learn what each controls so know how to play with them

…

On Oct 22, 2019 at 2:59 AM, darap89 ***@***.***> wrote: @gazehound I can't explain it right as my English isn't that good but did you remember to uncommint the 3 lines after you have changed the numbers — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

Answer 18 · 2019-10-25T00:31:19.000Z

I've tried 0, 400, 0 and 250, 250, 250 but nothing changes.
These are my lines starting at #56
#elif MB(MINIRAMBO) || MB(EINSY_RAMBO) || MB(EINSY_RETRO)
#define CPU_ST7920_DELAY_1 DELAY_NS(0)
#define CPU_ST7920_DELAY_2 DELAY_NS(400)
#define CPU_ST7920_DELAY_3 DELAY_NS(0)

Can anyone suggest what I have wrong?

Answer 19 · 2019-10-25T02:12:43.000Z

@lb4207 what board do you have mate ?

Answer 20 · 2019-10-25T02:18:24.000Z

MKS GEN L with RepRapDiscount Full Graphic Smart Controller.
I didn't have this problem before the Arduino 1.8.10 upgrade.
lb4207

Answer 21 · 2019-10-25T07:01:39.000Z

@lb4207 same her is just have an ramps 1,4.

open your autdino ang go to the tab called (ultralcd_st7920_u8glib_rrd.h)tab
And there is 3 lines where it says you can define your own.
I changed mine to:

#define ST7920_DELAY_1 DELAY_NS (0)
#define ST7920_DELAY_2 DELAY_NS (400)
#define ST7920_DELAY_3 DELAY_NS (0)

the tree line is at the start of the page,that's them you have to change since you have another board.when you change them to this they will overide the other delay settings.
I changed mine to what you see above and everything is working great With the screen.

Answer 22 · 2019-11-14T20:20:44.000Z

larsnordstrom's instructions worked for me with some modification:

Ok, then you need to add a condition to ultralcd_st7920_u8glib_rrd.h
locate line 56 and make sure it reads:
#elif MB(MINIRAMBO) || MB(EINSY_RAMBO)

Since my board is an MKS Gen (v1.4), I added it to the end of this line, so it reads:

#elif MB(MINIRAMBO) || MB(EINSY_RAMBO) || MB(MKS_GEN_13)

This solved this issue for me. Thanks larsnordstrom

Answer 23 · 2019-11-14T22:01:04.000Z

Can anyone suggest what I have wrong?

I found that if I added those lines to configuration.h it worked but they were not recognised in ultralcd_st7920_u8glib_rrd.h

Answer 24 · 2019-11-22T22:59:21.000Z

I've tried 0, 400, 0 and 250, 250, 250 but nothing changes.
These are my lines starting at #56
#elif MB(MINIRAMBO) || MB(EINSY_RAMBO) || MB(EINSY_RETRO)
#define CPU_ST7920_DELAY_1 DELAY_NS(0)
#define CPU_ST7920_DELAY_2 DELAY_NS(400)
#define CPU_ST7920_DELAY_3 DELAY_NS(0)
Can anyone suggest what I have wrong?

I found that if I added those lines to configuration.h it worked but they were not recognised in ultralcd_st7920_u8glib_rrd.h

Configuration.h

#define REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER
#define ST7920_DELAY_1 DELAY_NS(0)
#define ST7920_DELAY_2 DELAY_NS(400)
#define ST7920_DELAY_3 DELAY_NS(0)

It helped me. Thanks for telling me where to look for the problem

Answer 25 · 2019-11-25T22:20:31.000Z

I extended the queues of my screen 1 meter and same problem of display, my solution:
#define REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER

#define ST7920_DELAY_1 DELAY_NS (0)
#define ST7920_DELAY_2 DELAY_NS (250)
#define ST7920_DELAY_3 DELAY_NS (250)
good luck...

Answer 26 · 2019-12-15T20:25:44.000Z

Hi and thanks to every body!!! that fix my issue, used a mixed values (250,400,250) and it works perfectly.
I just wonder why after almost a year working fine it start glitching like that. the only thing that i did was to install my marlin 1.9 from always (whit my stuffs and configs) with a freshly updated Arduino IDE... but my libraries whas the same and everything was updated too... SOo i start wondering if i have something being broken on my controller...

Answer 27 · 2019-12-17T09:33:19.000Z

I have this issue with Marlin V2 can anyone advise how to modify V2 with these settings.

Answer 28 · 2019-12-17T09:39:08.000Z

I have just updated to V2 and No issue,but o guess it's the same folder you gave to go thru. Få Outlook til Android<https://aka.ms/ghei36>

…

________________________________ From: StockyJ <notifications@github.com> Sent: Tuesday, December 17, 2019 10:33:21 AM To: MarlinFirmware/Marlin <Marlin@noreply.github.com> Cc: darap89 <darap89@hotmail.dk>; Comment <comment@noreply.github.com> Subject: Re: [MarlinFirmware/Marlin] Reprap Discount Full Graphics Smart Controller Display is Garbled (#12003) I have this issue with Marlin V2 can anyone advise how to modify V2 with these settings. — You are receiving this because you commented. Reply to this email directly, view it on GitHub<#12003?email_source=notifications&email_token=AK4KNI6I77KFZSXIRH3VYWDQZCMGDA5CNFSM4FZAQTG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHBX6VI#issuecomment-566460245>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AK4KNI6SODBHYLDEA66BQQLQZCMGDANCNFSM4FZAQTGQ>.

Answer 29 · 2019-12-20T13:14:27.000Z

I extended the queues of my screen 1 meter and same problem of display, my solution:
#define REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER

#define ST7920_DELAY_1 DELAY_NS (0)
#define ST7920_DELAY_2 DELAY_NS (250)
#define ST7920_DELAY_3 DELAY_NS (250)
good luck...

thx,it solved my problem

Answer 30 · 2020-02-13T18:20:38.000Z

thanks for all 😃

Answer 31 · 2020-02-15T17:34:31.000Z

I've tried 0, 400, 0 and 250, 250, 250 but nothing changes.
These are my lines starting at #56
#elif MB(MINIRAMBO) || MB(EINSY_RAMBO) || MB(EINSY_RETRO)
#define CPU_ST7920_DELAY_1 DELAY_NS(0)
#define CPU_ST7920_DELAY_2 DELAY_NS(400)
#define CPU_ST7920_DELAY_3 DELAY_NS(0)
Can anyone suggest what I have wrong?

I found that if I added those lines to configuration.h it worked but they were not recognised in ultralcd_st7920_u8glib_rrd.h

Configuration.h

#define REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER
#define ST7920_DELAY_1 DELAY_NS(0)
#define ST7920_DELAY_2 DELAY_NS(400)
#define ST7920_DELAY_3 DELAY_NS(0)

It helped me. Thanks for telling me where to look for the problem

tanx, it solved my problem too

Answer 32 · 2020-05-01T14:34:22.000Z

结合上面各位的讨论，我找到一个能用的方法，已经在我的Ramps1.4主板上测试通过了：

记录下 Configuration.h里面的主板型号，我的主板是BOARD_RAMPS_14_EFB
#define MOTHERBOARD BOARD_RAMPS_14_EFB
打开ultralcd_st7920_u8glib_rrd.h，找到下面这一行代码（一般是在第56行）
#elif MB(MINIRAMBO) || MB(EINSY_RAMBO) || MB(EINSY_RETRO)
修改成如下内容
#elif MB(MINIRAMBO) || MB(EINSY_RAMBO) || MB(EINSY_RETRO)|| MB(RAMPS_14_EFB)
它的作用就是让下面的三行延时代码被执行，延时时间不用改。
完整的代码发出来，供大家参考

 #elif MB(MINIRAMBO) || MB(EINSY_RAMBO) || MB(EINSY_RETRO)|| MB(RAMPS_14_EFB) 
    #define CPU_ST7920_DELAY_1 DELAY_NS(0)
    #define CPU_ST7920_DELAY_2 DELAY_NS(250)  
    #define CPU_ST7920_DELAY_3 DELAY_NS(0)

Answer 33 · 2020-05-10T21:48:10.000Z

DAMN, why is this not fixed ?

Answer 34 · 2020-05-10T21:53:32.000Z

Hello This solution worked perfectly for me... I pased this 3 line code in configuration.v

…

On Mon, May 11, 2020, 2:18 AM avilab84 ***@***.***> wrote: DAMN, why is this not fixed ? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#12003 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AOSC47TLB63WHBPJUGLHGIDRQ4OKRANCNFSM4FZAQTGQ> .

Answer 35 · 2020-05-12T04:30:55.000Z

DAMN, why is this not fixed ?

It is patched in mainline Marlin. 🦦

Answer 36 · 2020-05-17T02:51:41.000Z

I extended the queues of my screen 1 meter and same problem of display, my solution:
#define REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER

#define ST7920_DELAY_1 DELAY_NS (0)
#define ST7920_DELAY_2 DELAY_NS (250)
#define ST7920_DELAY_3 DELAY_NS (250)
good luck...

Thanks! This solved my problem!!!

Answer 37 · 2020-07-16T14:03:35.000Z

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.