All_Parts_Laid_Out.svg AngleBrace1 error
Closed this issue · 10 comments
In the file "All_Parts_Laid_Out.svg" the patterns (2) for the part called 'AngleBrace1.svg' has a sub-mm inconsistency in its long sides.
This doesn't seem to exist in the "AngleBrace1.svg' file itself, just the "All_Parts_Laid_Out.svg" file. It's minor, but probably adds unnecessary complexity to the tool paths generated for this part using this consolidated file.
-mrfugu
Correction: This error appears on the long 90 deg edge of the AngleBrace1 shape, which appears 4x in the " "All_Parts_Laid_Out.svg" file
Good catch! Thanks for noticing that. If you want to make a pull request which fixes it, I would love to merge it. If not I'll look into correcting the issue.
Cool, will do it now.
this is my 1st Github contribution, apologies if I made a mess of it.
https://www.youtube.com/watch?v=iExgnVXSAuE
Well, the file is in my post, but it reads to me like i requested a merge of recently changed files as well, not my intent.
😀 You ARE helping!
It seems like maybe a bunch of other files got wrapped up in the pull request for some reason, maybe give signing the guest book a go to test the process out
The beautiful thing about Git Hub is it's virtually impossible to mess anything up. Every change is logged and reversible so you can pretty much always go for it! 👍 👍
Ok, I think I got it right this time, I re-submitted the corrected 'All_Parts_Laid_Out.svg' file.
Just merged it. Fantastic work! Thank you.
👍 👍 👍